Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1808663004: Un-deprecate new methods to fix Android. (Closed)

Created:
4 years, 9 months ago by dogben
Modified:
4 years, 9 months ago
CC:
reviews_skia.org, djsollen
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/core/SkGlyph.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dogben
4 years, 9 months ago (2016-03-16 20:35:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808663004/1
4 years, 9 months ago (2016-03-16 20:35:58 UTC) #5
djsollen
lgtm
4 years, 9 months ago (2016-03-16 20:49:44 UTC) #7
djsollen
also feel free to guard them behind SK_BUILD_FOR_ANDROID_FRAMEWORK if you want.
4 years, 9 months ago (2016-03-16 20:50:25 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 20:58:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808663004/1
4 years, 9 months ago (2016-03-16 21:00:36 UTC) #12
mtklein
On 2016/03/16 20:50:25, djsollen wrote: > also feel free to guard them behind SK_BUILD_FOR_ANDROID_FRAMEWORK if ...
4 years, 9 months ago (2016-03-16 21:00:47 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 21:01:45 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2732e186a1132f91fbacd3509e2a990731f4e13c

Powered by Google App Engine
This is Rietveld 408576698