chrome/browser/supervised_user/supervised_user_navigation_observer.h - Issue 1808653003: Move the supervised user error page to a component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_navigation_observer.h

Issue 1808653003: Move the supervised user error page to a component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to fix compile problem Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_interstitial.cc ('k') | chrome/browser/supervised_user/supervised_user_navigation_observer.cc » ('j') | components/resources/OWNERS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_navigation_observer.h

diff --git a/chrome/browser/supervised_user/supervised_user_navigation_observer.h b/chrome/browser/supervised_user/supervised_user_navigation_observer.h

index 4783f4a4c407e38d9f49cd0bd40638c102a99aec..6b1e237fb5ca6f86aad3e0fd7ad18ceaa9825232 100644

--- a/chrome/browser/supervised_user/supervised_user_navigation_observer.h

+++ b/chrome/browser/supervised_user/supervised_user_navigation_observer.h

@@ -13,6 +13,7 @@

#include "chrome/browser/supervised_user/supervised_user_url_filter.h"

#include "chrome/browser/supervised_user/supervised_users.h"

#include "components/sessions/core/serialized_navigation_entry.h"

+#include "components/supervised_user_error_page/supervised_user_error_page.h"

#include "content/public/browser/resource_request_info.h"

#include "content/public/browser/web_contents_user_data.h"

@@ -39,7 +40,7 @@ class SupervisedUserNavigationObserver

const content::ResourceRequestInfo::WebContentsGetter&

web_contents_getter,

const GURL& url,

- SupervisedUserURLFilter::FilteringBehaviorReason reason,

+ supervised_user_error_page::FilteringBehaviorReason reason,

const base::Callback<void(bool)>& callback);

// SupervisedUserServiceObserver implementation.

@@ -48,7 +49,7 @@ class SupervisedUserNavigationObserver

void URLFilterCheckCallback(

const GURL& url,

SupervisedUserURLFilter::FilteringBehavior behavior,

- SupervisedUserURLFilter::FilteringBehaviorReason reason,

+ supervised_user_error_page::FilteringBehaviorReason reason,

bool uncertain);

private: