Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/android/bb_run_sharded_steps.py

Issue 18086004: Move Python setup/tear down logic into Forwarder itself. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implement Marcus' idea Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android/adb_reverse_forwarder.py ('K') | « build/android/adb_reverse_forwarder.py ('k') | build/android/pylib/base/base_test_runner.py » ('j') | build/android/pylib/base/base_test_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/bb_run_sharded_steps.py
diff --git a/build/android/bb_run_sharded_steps.py b/build/android/bb_run_sharded_steps.py
index afd354a32e2e916857c28e642d5d4409178849dd..512fc5ca14a7d7ccd7e4de17a540337b4e56ead3 100755
--- a/build/android/bb_run_sharded_steps.py
+++ b/build/android/bb_run_sharded_steps.py
@@ -165,7 +165,6 @@ def _PrintAllStepsOutput(steps):
def _KillPendingServers():
for retry in range(5):
- forwarder.Forwarder.KillHost()
for server in ['lighttpd', 'web-page-replay']:
pids = cmd_helper.GetCmdOutput(['pgrep', '-f', server])
pids = [pid.strip() for pid in pids.split('\n') if pid.strip()]
@@ -201,6 +200,8 @@ def main(argv):
# previous runs.
_KillPendingServers()
+ forwarder.Forwarder.use_multiprocessing()
bulach 2013/07/15 17:51:43 nit: UseMultiprocessing(), but more below!
Philippe 2013/07/16 12:31:21 Oops :)
+
# Reset the test port allocation. It's important to do it before starting
# to dispatch any step.
if not ports.ResetTestServerPortAllocation():
« build/android/adb_reverse_forwarder.py ('K') | « build/android/adb_reverse_forwarder.py ('k') | build/android/pylib/base/base_test_runner.py » ('j') | build/android/pylib/base/base_test_runner.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698