Move Python setup/tear down logic into Forwarder itself.

chrome/test/chromedriver/test_environment.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """TestEnvironment classes.
 
 These classes abstract away the various setups needed to run the WebDriver java
 tests in various environments.
 """
 
@@ skipping 76 matching lines @@
   def __init__(self, chrome_version='HEAD'):
     super(AndroidTestEnvironment, self).__init__(chrome_version)
     self._adb = None
     self._forwarder = None
 
   # override
   def GlobalSetUp(self):
     os.putenv('TEST_HTTP_PORT', str(ANDROID_TEST_HTTP_PORT))
     os.putenv('TEST_HTTPS_PORT', str(ANDROID_TEST_HTTPS_PORT))
     self._adb = android_commands.AndroidCommands()
-    self._forwarder = forwarder.Forwarder(self._adb, 'Debug')
-    self._forwarder.Run(
+    forwarder.Forwarder.Map(

[frankf, 2013/07/15 22:23:22]

Same here.

[Philippe, 2013/07/16 12:31:21]

Done.

         [(ANDROID_TEST_HTTP_PORT, ANDROID_TEST_HTTP_PORT),
          (ANDROID_TEST_HTTPS_PORT, ANDROID_TEST_HTTPS_PORT)],
-        valgrind_tools.BaseTool())
+        self._adb)
 
   # override
   def GlobalTearDown(self):
-    if self._adb is not None:
-      forwarder.Forwarder.KillDevice(self._adb, valgrind_tools.BaseTool())
-    if self._forwarder is not None:
-      self._forwarder.Close()
+    for device_port in [ANDROID_TEST_HTTP_PORT, ANDROID_TEST_HTTPS_PORT]:
+      forwarder.Forwarder.UnmapDevicePort(device_port, self._adb)
 
   # override
   def GetOS(self):
     return 'android'