Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Side by Side Diff: chrome/test/chromedriver/run_py_tests.py

Issue 18086004: Move Python setup/tear down logic into Forwarder itself. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implement Marcus' idea Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """End to end tests for ChromeDriver.""" 6 """End to end tests for ChromeDriver."""
7 7
8 import base64 8 import base64
9 import optparse 9 import optparse
10 import os 10 import os
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 136
137 class ChromeDriverTest(ChromeDriverBaseTest): 137 class ChromeDriverTest(ChromeDriverBaseTest):
138 """End to end tests for ChromeDriver.""" 138 """End to end tests for ChromeDriver."""
139 139
140 @staticmethod 140 @staticmethod
141 def GlobalSetUp(): 141 def GlobalSetUp():
142 ChromeDriverTest._http_server = webserver.WebServer( 142 ChromeDriverTest._http_server = webserver.WebServer(
143 chrome_paths.GetTestData()) 143 chrome_paths.GetTestData())
144 if _ANDROID_PACKAGE: 144 if _ANDROID_PACKAGE:
145 ChromeDriverTest._adb = android_commands.AndroidCommands() 145 ChromeDriverTest._adb = android_commands.AndroidCommands()
146 ChromeDriverTest._forwarder = forwarder.Forwarder(ChromeDriverTest._adb, 146 self._host_port = ChromeDriverTest._http_server._server.server_port
frankf 2013/07/15 22:23:22 You need to rebase, KillHost was added here.
Philippe 2013/07/16 12:31:21 Indeed :)
147 'Debug') 147 forwarder.Forwarder.Map(
148 host_port = ChromeDriverTest._http_server._server.server_port 148 [(self._host_port, self._host_port)], ChromeDriverTest._adb)
149 ChromeDriverTest._forwarder.Run(
150 [(host_port, host_port)], valgrind_tools.BaseTool())
151 149
152 @staticmethod 150 @staticmethod
153 def GlobalTearDown(): 151 def GlobalTearDown():
154 if _ANDROID_PACKAGE: 152 if _ANDROID_PACKAGE:
155 forwarder.Forwarder.KillDevice(ChromeDriverTest._adb, 153 forwarder.Forwarder.UnmapDevicePort(
156 valgrind_tools.BaseTool()) 154 self._host_port, ChromeDriverTest._adb)
157 ChromeDriverTest._forwarder.Close()
158 ChromeDriverTest._http_server.Shutdown() 155 ChromeDriverTest._http_server.Shutdown()
159 156
160 @staticmethod 157 @staticmethod
161 def GetHttpUrlForFile(file_path): 158 def GetHttpUrlForFile(file_path):
162 return ChromeDriverTest._http_server.GetUrl() + file_path 159 return ChromeDriverTest._http_server.GetUrl() + file_path
163 160
164 def setUp(self): 161 def setUp(self):
165 self._driver = self.CreateDriver() 162 self._driver = self.CreateDriver()
166 163
167 def testStartStop(self): 164 def testStartStop(self):
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 negative_filter = _GetDesktopNegativeFilter(options.chrome_version) 736 negative_filter = _GetDesktopNegativeFilter(options.chrome_version)
740 options.filter = '*-' + ':__main__.'.join([''] + negative_filter) 737 options.filter = '*-' + ':__main__.'.join([''] + negative_filter)
741 738
742 all_tests_suite = unittest.defaultTestLoader.loadTestsFromModule( 739 all_tests_suite = unittest.defaultTestLoader.loadTestsFromModule(
743 sys.modules[__name__]) 740 sys.modules[__name__])
744 tests = unittest_util.FilterTestSuite(all_tests_suite, options.filter) 741 tests = unittest_util.FilterTestSuite(all_tests_suite, options.filter)
745 ChromeDriverTest.GlobalSetUp() 742 ChromeDriverTest.GlobalSetUp()
746 result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(tests) 743 result = unittest.TextTestRunner(stream=sys.stdout, verbosity=2).run(tests)
747 ChromeDriverTest.GlobalTearDown() 744 ChromeDriverTest.GlobalTearDown()
748 sys.exit(len(result.failures) + len(result.errors)) 745 sys.exit(len(result.failures) + len(result.errors))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698