Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1808593003: [Autofill] Add regex for phone field. (Closed)

Created:
4 years, 9 months ago by sebsg
Modified:
4 years, 9 months ago
CC:
bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, chromium-reviews, estade+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, rouslan+autofill_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Since the site hal-india.com uses "Contact Number" to label phone number fields, the regex "contact.?number" was added. BUG=594090 TEST=FormStructureBrowserTest Committed: https://crrev.com/25b58830ea3a933a25700962f6c72b97720444fb Cr-Commit-Position: refs/heads/master@{#381453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -8 lines) Patch
A chrome/test/data/autofill/heuristics/input/145_hal-india.com.html View 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/145_hal-india.com.out View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.cc View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
sebsg
PTAL?
4 years, 9 months ago (2016-03-16 13:40:41 UTC) #3
vabr (Chromium)
LGTM, I could not think of a label matching the new regexp which would not ...
4 years, 9 months ago (2016-03-16 14:00:31 UTC) #5
Mathieu
lgtm
4 years, 9 months ago (2016-03-16 14:07:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808593003/1
4 years, 9 months ago (2016-03-16 14:10:26 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 15:08:18 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 15:09:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25b58830ea3a933a25700962f6c72b97720444fb
Cr-Commit-Position: refs/heads/master@{#381453}

Powered by Google App Engine
This is Rietveld 408576698