Add a stub implementation for Mojo AudioDecoder interface

Add a stub implementation for Mojo AudioDecoder interface

This CL adds a stub service that implements interface::AudioDecoder.
The interface is modified to pass the AudioDecoderClient which
can transfer the results back to the proxy.

BUG=542910
Committed: https://crrev.com/0adc0178a182e7ab2d74f729bc70987c6c5b9234
Cr-Commit-Position: refs/heads/master@{#381574}

[Tima Vaisburd, 2016-03-16 01:15:31]

timav@chromium.org changed reviewers:
+ sandersd@chromium.org, xhwang@chromium.org

[Tima Vaisburd, 2016-03-16 01:15:31]

PTAL

[xhwang, 2016-03-16 04:12:18]

LGTM with nits

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder_service.cc (right):

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.cc:22: NOTIMPLEMENTED();
If you run this code now it'll warn you that the callback is dropped (not
returned). So just have a dummy implementation here, e.g. callback.Run(false).

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.cc:27: NOTIMPLEMENTED();
ditto about callback

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.cc:31: NOTIMPLEMENTED();
ditto about callback

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder_service.h (right):

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:9: //#include
"base/memory/ref_counted.h"
fix the "//" here.

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:11: //#include
"base/memory/weak_ptr.h"
fix the "//" here.

[xhwang, 2016-03-16 04:21:58]

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder_service.h (right):

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:20: scoped_ptr<AudioDecoder>
decoder,
BTW, I assume you'll create the AudioDecoder in AndroidMojoMediaClient, and pass
the |decoder| here.

In the next CL, in MojoMediaClient you'll add a call CreateAudioDecoder() and
implement it in AndrdoiMojoMediaClient.

Note that CreateAudioDecoder() returns nullptr by default. So the proxy side
needs to handle this. Usually this results in a connection error. Here's an
example how to handle it:

https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...

[Tima Vaisburd, 2016-03-16 19:23:20]

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder_service.cc (right):

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.cc:22: NOTIMPLEMENTED();
On 2016/03/16 04:12:17, xhwang wrote:
> If you run this code now it'll warn you that the callback is dropped (not
> returned). So just have a dummy implementation here, e.g. callback.Run(false).

Done.

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.cc:27: NOTIMPLEMENTED();
On 2016/03/16 04:12:17, xhwang wrote:
> ditto about callback

Done.

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.cc:31: NOTIMPLEMENTED();
On 2016/03/16 04:12:18, xhwang wrote:
> ditto about callback

Done.

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder_service.h (right):

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:9: //#include
"base/memory/ref_counted.h"
On 2016/03/16 04:12:18, xhwang wrote:
> fix the "//" here.

Done.

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:11: //#include
"base/memory/weak_ptr.h"
On 2016/03/16 04:12:18, xhwang wrote:
> fix the "//" here.

Done.

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:20: scoped_ptr<AudioDecoder>
decoder,
On 2016/03/16 04:21:58, xhwang wrote:
> BTW, I assume you'll create the AudioDecoder in AndroidMojoMediaClient, and
pass
> the |decoder| here.
> 
> In the next CL, in MojoMediaClient you'll add a call CreateAudioDecoder() and
> implement it in AndrdoiMojoMediaClient.
> 
> Note that CreateAudioDecoder() returns nullptr by default. So the proxy side
> needs to handle this. Usually this results in a connection error. Here's an
> example how to handle it:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...

In the doc you mentioned ServiceFactoryImpl. Should it delegate everything to
MojoMediaClient? I put this note in the doc.

[xhwang, 2016-03-16 19:51:41]

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
File media/mojo/services/mojo_audio_decoder_service.h (right):

https://codereview.chromium.org/1808593002/diff/20001/media/mojo/services/moj...
media/mojo/services/mojo_audio_decoder_service.h:20: scoped_ptr<AudioDecoder>
decoder,
On 2016/03/16 19:23:20, Tima Vaisburd wrote:
> On 2016/03/16 04:21:58, xhwang wrote:
> > BTW, I assume you'll create the AudioDecoder in AndroidMojoMediaClient, and
> pass
> > the |decoder| here.
> > 
> > In the next CL, in MojoMediaClient you'll add a call CreateAudioDecoder()
and
> > implement it in AndrdoiMojoMediaClient.
> > 
> > Note that CreateAudioDecoder() returns nullptr by default. So the proxy side
> > needs to handle this. Usually this results in a connection error. Here's an
> > example how to handle it:
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service...
> 
> In the doc you mentioned ServiceFactoryImpl. Should it delegate everything to
> MojoMediaClient? I put this note in the doc.

Sorry for the confusion. Yes, platform specific implementations should go to
MojoMediaClient.

[Tima Vaisburd, 2016-03-16 22:11:55]

The CQ bit was checked by timav@chromium.org

[Tima Vaisburd, 2016-03-16 22:11:56]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1808593002/#ps60001
(title: "Rebased")

[commit-bot: I haz the power, 2016-03-16 22:12:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808593002/60001

[commit-bot: I haz the power, 2016-03-16 22:54:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-16 23:00:29]

Description was changed from

==========
Add a stub implementation for Mojo AudioDecoder interface

This CL adds a stub service that implements interface::AudioDecoder.
The interface is modified to pass the AudioDecoderClient which
can transfer the results back to the proxy.

BUG=542910
==========

to

==========
Add a stub implementation for Mojo AudioDecoder interface

This CL adds a stub service that implements interface::AudioDecoder.
The interface is modified to pass the AudioDecoderClient which
can transfer the results back to the proxy.

BUG=542910

Committed: https://crrev.com/0adc0178a182e7ab2d74f729bc70987c6c5b9234
Cr-Commit-Position: refs/heads/master@{#381574}
==========

[commit-bot: I haz the power, 2016-03-16 23:00:30]

Patchset 4 (id:??) landed as
https://crrev.com/0adc0178a182e7ab2d74f729bc70987c6c5b9234
Cr-Commit-Position: refs/heads/master@{#381574}