Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1808583003: Mojo C++ bindings: MultiplexRouter more aggressively dispatch queued messages. (Closed)

Created:
4 years, 9 months ago by yzshen1
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: MultiplexRouter more aggressively dispatch queued messages. This CL allows MultiplexRouter to dispatch multiple queued messages to clients without returning to the message loop. This way we may starve other tasks on the same thread, but we have been doing the same thing in the non-associated-interface case (see Connector::ReadAllAvailableMessages). So it is probably okay. BUG=590495 Committed: https://crrev.com/51fec73df69c66596985a9037bc0665529327507 Cr-Commit-Position: refs/heads/master@{#381514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -13 lines) Patch
M mojo/public/cpp/bindings/lib/multiplex_router.h View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yzshen1
Hi, Ken. Please take a look. Thanks! This CL probably doesn't improve the numbers of ...
4 years, 9 months ago (2016-03-16 17:44:00 UTC) #2
Ken Rockot(use gerrit already)
Cool, LGTM!
4 years, 9 months ago (2016-03-16 18:05:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808583003/1
4 years, 9 months ago (2016-03-16 18:08:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 19:46:53 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 19:48:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51fec73df69c66596985a9037bc0665529327507
Cr-Commit-Position: refs/heads/master@{#381514}

Powered by Google App Engine
This is Rietveld 408576698