Precompilation: don't include an object header for instructions in the text section.

Precompilation: don't include an object header for instructions in the text section.

Reference Instructions only through Code::entry_point_ (or Function::entry_point_). Store the instructions size in its corresponding Code object.

precompiled dart2js x64 22163470 -> 21621102 (-2.45%)

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/b2f3e8efe1f32bacad99ddbedbc434a6102d8be2

[rmacnak, 2016-03-23 23:28:32]

Description was changed from

==========
stashing for diff upload

BUG=
==========

to

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.
==========

[rmacnak, 2016-03-23 23:39:39]

Description was changed from

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.
==========

to

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.
==========

[rmacnak, 2016-03-24 00:04:08]

Description was changed from

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.
==========

to

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.

precompiled dart2js x64 22163470 -> 21621102 (-2.45%)
==========

[rmacnak, 2016-03-24 00:05:39]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, srdjan@google.com

[Florian Schneider, 2016-03-28 22:15:47]

lgtm

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/raw_object_...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:1386: (*reader->ObjectPoolHandle()) ^=
reader->ReadObjectImpl(kAsReference);
Also use PassiveObjectHandle for consistency with the other fields?

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:1409: (*reader->ArrayHandle()) ^=
reader->ReadObjectImpl(kAsReference);
PassiveObjectHandle?

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (left):

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/stack_frame...
runtime/vm/stack_frame.cc:384: (frames_.HasNext()) ?
frames_.NextFrame(validate_) : NextEntryFrame();
What's wrong with using the conditional expression?

[rmacnak, 2016-03-28 23:56:45]

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/raw_object_...
File runtime/vm/raw_object_snapshot.cc (right):

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:1386: (*reader->ObjectPoolHandle()) ^=
reader->ReadObjectImpl(kAsReference);
On 2016/03/28 22:15:47, Florian Schneider wrote:
> Also use PassiveObjectHandle for consistency with the other fields?

Done.

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/raw_object_...
runtime/vm/raw_object_snapshot.cc:1409: (*reader->ArrayHandle()) ^=
reader->ReadObjectImpl(kAsReference);
On 2016/03/28 22:15:47, Florian Schneider wrote:
> PassiveObjectHandle?

Done.

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/stack_frame.cc
File runtime/vm/stack_frame.cc (left):

https://codereview.chromium.org/1808553002/diff/160001/runtime/vm/stack_frame...
runtime/vm/stack_frame.cc:384: (frames_.HasNext()) ?
frames_.NextFrame(validate_) : NextEntryFrame();
On 2016/03/28 22:15:47, Florian Schneider wrote:
> What's wrong with using the conditional expression?

Nothing, I had print here debugger earlier. Undone.

[rmacnak, 2016-03-29 18:04:08]

Description was changed from

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.

precompiled dart2js x64 22163470 -> 21621102 (-2.45%)
==========

to

==========
Precompilation: don't include an object header for instructions in the text
section.

Reference Instructions only through Code::entry_point_ (or
Function::entry_point_). Store the instructions size in its corresponding Code
object.

precompiled dart2js x64 22163470 -> 21621102 (-2.45%)

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b2f3e8efe1f32bacad99ddbedbc434a6102d8be2
==========

[rmacnak, 2016-03-29 18:04:09]

Committed patchset #10 (id:180001) manually as
b2f3e8efe1f32bacad99ddbedbc434a6102d8be2 (presubmit successful).