Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1808543002: Revert of Update V8 to version 5.1.127. (Closed)

Created:
4 years, 9 months ago by dewittj
Modified:
4 years, 9 months ago
CC:
chromium-reviews, Hannes Payer (out of office)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.1.127. (patchset #1 id:1 of https://codereview.chromium.org/1799403002/ ) Reason for revert: This appears to make several tests flaky. See crbug.com/595092 Original issue's description: > Update V8 to version 5.1.127. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/2b8fdcf7..da7cc15c > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/79277ce2a7897fcc7cb78acd7383e28c7c2129e0 > Cr-Commit-Position: refs/heads/master@{#381190} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a585630b19d3932b181559465d05b908ea9bc116 Cr-Commit-Position: refs/heads/master@{#381343}

Patch Set 1 #

Patch Set 2 : Rebase with origin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dewittj
Created Revert of Update V8 to version 5.1.127.
4 years, 9 months ago (2016-03-15 22:56:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808543002/40001
4 years, 9 months ago (2016-03-15 23:03:19 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 9 months ago (2016-03-15 23:04:00 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a585630b19d3932b181559465d05b908ea9bc116 Cr-Commit-Position: refs/heads/master@{#381343}
4 years, 9 months ago (2016-03-15 23:07:18 UTC) #6
adamk
4 years, 9 months ago (2016-03-15 23:14:02 UTC) #8
Message was sent while issue was closed.
In particular, turning on black allocation
(https://codereview.chromium.org/1800733002) is the suspect here.

Powered by Google App Engine
This is Rietveld 408576698