Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: media/blink/webmediaplayer_impl.cc

Issue 1808473002: Log a non-crash dump for 10% of Spitzer pipeline decode failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/webmediaplayer_impl.cc
diff --git a/media/blink/webmediaplayer_impl.cc b/media/blink/webmediaplayer_impl.cc
index 2cd76805d0e0dfeae4994bbb8f3520d7ffd61696..7f205f018faf8c7c18067db36c9cb62625d93e22 100644
--- a/media/blink/webmediaplayer_impl.cc
+++ b/media/blink/webmediaplayer_impl.cc
@@ -17,7 +17,9 @@
#include "base/command_line.h"
#include "base/debug/alias.h"
#include "base/debug/crash_logging.h"
+#include "base/debug/dump_without_crashing.h"
#include "base/metrics/histogram.h"
+#include "base/rand_util.h"
#include "base/single_thread_task_runner.h"
#include "base/synchronization/waitable_event.h"
#include "base/task_runner_util.h"
@@ -910,6 +912,16 @@ void WebMediaPlayerImpl::OnPipelineError(PipelineStatus error) {
if (suppress_destruction_errors_)
return;
+#if defined(OS_ANDROID)
+ // For 10% of pipeline decode failures log the playback URL. The URL is set
+ // as the crash-key 'subresource_url' during DoLoad().
+ //
+ // TODO(dalecurtis): This is temporary to track down higher than average
+ // decode failure rates for video-only content. See http://crbug.com/595076.
+ if (base::RandDouble() <= 0.1 && error == PIPELINE_ERROR_DECODE)
+ base::debug::DumpWithoutCrashing();
+#endif
+
media_log_->AddEvent(media_log_->CreatePipelineErrorEvent(error));
if (ready_state_ == WebMediaPlayer::ReadyStateHaveNothing) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698