Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1808433003: Fix build issue of missing BackingStrategy vtable. (Closed)

Created:
4 years, 9 months ago by avallee
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build issue of missing BackingStrategy vtable. 338ac3d5778afc85b741bafc778d2301eb272bfa added UpdatePictureBufferSize virtual without being pure or having a definition. This change marks the method as pure virtual. BUG=595070 Committed: https://crrev.com/1c8c830c0f2053be82235493b3b96acfb1dbc807 Cr-Commit-Position: refs/heads/master@{#381294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/common/gpu/media/android_video_decode_accelerator.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
avallee
PTAL.
4 years, 9 months ago (2016-03-15 18:50:21 UTC) #2
DaleCurtis
lgtm
4 years, 9 months ago (2016-03-15 18:53:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808433003/1
4 years, 9 months ago (2016-03-15 18:54:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 19:57:47 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 19:59:56 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c8c830c0f2053be82235493b3b96acfb1dbc807
Cr-Commit-Position: refs/heads/master@{#381294}

Powered by Google App Engine
This is Rietveld 408576698