Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: third_party/pkg/angular/lib/directive/ng_a.dart

Issue 180843004: Revert revision 33053 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/lib/directive/ng_a.dart
===================================================================
--- third_party/pkg/angular/lib/directive/ng_a.dart (revision 33054)
+++ third_party/pkg/angular/lib/directive/ng_a.dart (working copy)
@@ -7,7 +7,7 @@
*
* @description
* Modifies the default behavior of the html A tag so that the default action is prevented when
- * the a href is empty or it contains `ng-click` directive.
+ * the href attribute is empty.
*
* This change permits the easy creation of action links with the `ngClick` directive
* without changing the location or causing page reloads, e.g.:
@@ -15,11 +15,10 @@
*/
@NgDirective(selector: 'a[href]')
class NgADirective {
- final dom.Element element;
+ dom.Element element;
- NgADirective(this.element) {
- if (element.attributes["href"] == "" ||
- element.attributes.containsKey('ng-click')) {
+ NgADirective(dom.Element element) {
+ if (element.attributes["href"] == "") {
element.onClick.listen((event) {
if (element.attributes["href"] == "") {
event.preventDefault();
« no previous file with comments | « third_party/pkg/angular/lib/directive/module.dart ('k') | third_party/pkg/angular/lib/directive/ng_bind.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698