Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/pkg/angular/lib/directive/ng_include.dart

Issue 180843004: Revert revision 33053 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/pkg/angular/lib/directive/ng_include.dart
===================================================================
--- third_party/pkg/angular/lib/directive/ng_include.dart (revision 33054)
+++ third_party/pkg/angular/lib/directive/ng_include.dart (working copy)
@@ -17,25 +17,26 @@
*/
@NgDirective(
selector: '[ng-include]',
- map: const {'ng-include': '@url'})
+ map: const {'ng-include': '@url'} )
class NgIncludeDirective {
- final dom.Element element;
- final Scope scope;
- final BlockCache blockCache;
- final Injector injector;
- final DirectiveMap directives;
+ dom.Element element;
+ Scope scope;
+ BlockCache blockCache;
+ Injector injector;
Block _previousBlock;
Scope _previousScope;
- NgIncludeDirective(this.element, this.scope, this.blockCache, this.injector, this.directives);
+ NgIncludeDirective(this.element, this.scope, this.blockCache, this.injector);
_cleanUp() {
- if (_previousBlock == null) return;
+ if (_previousBlock == null) {
+ return;
+ }
_previousBlock.remove();
- _previousScope.destroy();
+ _previousScope.$destroy();
element.innerHtml = '';
_previousBlock = null;
@@ -44,9 +45,8 @@
_updateContent(createBlock) {
// create a new scope
- _previousScope = scope.createChild(new PrototypeMap(scope.context));
- _previousBlock = createBlock(injector.createChild([new Module()
- ..value(Scope, _previousScope)]));
+ _previousScope = scope.$new();
+ _previousBlock = createBlock(injector.createChild([new Module()..value(Scope, _previousScope)]));
_previousBlock.elements.forEach((elm) => element.append(elm));
}
@@ -55,7 +55,7 @@
set url(value) {
_cleanUp();
if (value != null && value != '') {
- blockCache.fromUrl(value, directives).then(_updateContent);
+ blockCache.fromUrl(value).then(_updateContent);
}
}
}
« no previous file with comments | « third_party/pkg/angular/lib/directive/ng_if.dart ('k') | third_party/pkg/angular/lib/directive/ng_model.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698