Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 18084012: Delete time forwarding headers. (Closed)

Created:
7 years, 5 months ago by Avi (use Gerrit)
Modified:
7 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Delete time forwarding headers. BUG=254986 TEST=none TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209164

Patch Set 1 #

Patch Set 2 : missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
D base/time.h View 1 chunk +0 lines, -7 lines 0 comments Download
D base/timer.h View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/autocheckout_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/autocheckout_statistic.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Committed patchset #2 manually as r209164 (presubmit successful).
7 years, 5 months ago (2013-06-28 16:51:08 UTC) #1
Ben Goodger (Google)
7 years, 5 months ago (2013-06-28 16:53:08 UTC) #2
lgtm


On Fri, Jun 28, 2013 at 9:51 AM, <avi@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> Committed patchset #2 manually as r209164 (presubmit successful).
>
> Description:
> Delete time forwarding headers.
>
> BUG=254986
> TEST=none
> TBR=ben@chromium.org
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=209164<https://src.chromium.org/viewvc/chrome?view=rev&revision=209164>
>
> Please review this at
https://codereview.chromium.**org/18084012/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   D base/time.h
>   D base/timer.h
>   M chrome/browser/extensions/api/**location/location_manager.cc
>   M components/autofill/content/**browser/autocheckout_manager.h
>   M components/autofill/content/**browser/autocheckout_**statistic.h
>
>
> Index: base/time.h
> diff --git a/base/time.h b/base/time.h
> deleted file mode 100644
> index 2a7df7dc5139419ae042eca1d3f784**3ffb23ba91..**
> 000000000000000000000000000000**0000000000
> --- a/base/time.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -// Copyright 2013 The Chromium Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style license that can be
> -// found in the LICENSE file.
> -
> -// This file has moved, please use the new location.
> -// TODO(avi): Remove this file when all users have been updated.
> -#include "base/time/time.h"
> Index: base/timer.h
> diff --git a/base/timer.h b/base/timer.h
> deleted file mode 100644
> index b594d5d4c493063be3688502750bae**9ba90a86b2..**
> 000000000000000000000000000000**0000000000
> --- a/base/timer.h
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -// Copyright 2013 The Chromium Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style license that can be
> -// found in the LICENSE file.
> -
> -// This file has moved, please use the new location.
> -// TODO(avi): Remove this file when all users have been updated.
> -#include "base/timer/timer.h"
> Index: chrome/browser/extensions/api/**location/location_manager.cc
> diff --git a/chrome/browser/extensions/**api/location/location_manager.**cc
> b/chrome/browser/extensions/**api/location/location_manager.**cc
> index 77da5a03dc3a7561d6853c0927c104**b5f0b0afb2..**
> 173a44a6300ba12e00d1e6faa1fcc1**7c891784f3 100644
> --- a/chrome/browser/extensions/**api/location/location_manager.**cc
> +++ b/chrome/browser/extensions/**api/location/location_manager.**cc
> @@ -9,7 +9,7 @@
>
>  #include "base/bind.h"
>  #include "base/lazy_instance.h"
> -#include "base/time.h"
> +#include "base/time/time.h"
>  #include "chrome/browser/extensions/**event_router.h"
>  #include "chrome/browser/extensions/**extension_system.h"
>  #include "chrome/common/chrome_**notification_types.h"
> Index: components/autofill/content/**browser/autocheckout_manager.h
> diff --git a/components/autofill/content/**browser/autocheckout_manager.h
> b/components/autofill/content/**browser/autocheckout_manager.h
> index eec00f2678e701408ec5278b6848df**3863e0a5df..**
> 84faf66421df4caadaa417fd08b925**c87a3fc861 100644
> --- a/components/autofill/content/**browser/autocheckout_manager.h
> +++ b/components/autofill/content/**browser/autocheckout_manager.h
> @@ -12,7 +12,7 @@
>  #include "base/memory/weak_ptr.h"
>  #include "base/strings/string16.h"
>  #include "base/threading/thread_**checker.h"
> -#include "base/time.h"
> +#include "base/time/time.h"
>  #include "components/autofill/content/**browser/autocheckout_page_**
> meta_data.h"
>  #include "components/autofill/content/**browser/autocheckout_**
> statistic.h"
>  #include "components/autofill/core/**common/autocheckout_status.h"
> Index: components/autofill/content/**browser/autocheckout_**statistic.h
> diff --git a/components/autofill/content/**browser/autocheckout_**statistic.h
> b/components/autofill/content/**browser/autocheckout_**statistic.h
> index 8720a9fad1289509bbcdc7ee0be9a3**584295d2c0..**
> 74f7df7cd9bea063e76b6a8e51e069**cd8963fa18 100644
> --- a/components/autofill/content/**browser/autocheckout_**statistic.h
> +++ b/components/autofill/content/**browser/autocheckout_**statistic.h
> @@ -8,7 +8,7 @@
>  #include <vector>
>
>  #include "base/memory/scoped_ptr.h"
> -#include "base/time.h"
> +#include "base/time/time.h"
>  #include "components/autofill/content/**browser/autocheckout_steps.h"
>
>  namespace base {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698