Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1808393002: SDK fixes (Closed)

Created:
4 years, 9 months ago by Leaf
Modified:
4 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -80 lines) Patch
M lib/runtime/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/async/stream.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tool/input_sdk/lib/internal/iterable.dart View 32 chunks +63 lines, -49 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Leaf
Note: changes to iterable.dart are just from running the formatter.
4 years, 9 months ago (2016-03-17 23:49:26 UTC) #3
Bob Nystrom
lgtm https://codereview.chromium.org/1808393002/diff/1/tool/input_sdk/lib/internal/iterable.dart File tool/input_sdk/lib/internal/iterable.dart (right): https://codereview.chromium.org/1808393002/diff/1/tool/input_sdk/lib/internal/iterable.dart#newcode176 tool/input_sdk/lib/internal/iterable.dart:176: new MappedListIterable<E, dynamic/*=T*/ >(this, f); The space after ...
4 years, 9 months ago (2016-03-18 00:34:51 UTC) #4
Leaf
https://codereview.chromium.org/1808393002/diff/1/tool/input_sdk/lib/internal/iterable.dart File tool/input_sdk/lib/internal/iterable.dart (right): https://codereview.chromium.org/1808393002/diff/1/tool/input_sdk/lib/internal/iterable.dart#newcode176 tool/input_sdk/lib/internal/iterable.dart:176: new MappedListIterable<E, dynamic/*=T*/ >(this, f); On 2016/03/18 00:34:51, Bob ...
4 years, 9 months ago (2016-03-18 00:48:22 UTC) #5
Leaf
4 years, 9 months ago (2016-03-18 00:49:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
27833189352c783e4a2f35e4e082f4e5538f0a14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698