Implement ES2015 labelled function declaration restrictions

test/cctest/test-parsing.cc

Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 16139a56e5c51bf9d6aee12aff9a59a5aca333b1..800f1b6870518a4d0e900c515e91865febf0a13c 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -7270,10 +7270,13 @@ TEST(FunctionDeclarationError) {
     {"(function() { {", "} })()"},
     { NULL, NULL }
   };
+  // Invalid in all contexts
   const char* error_data[] = {
     "try function foo() {} catch (e) {}",
     NULL
   };
+  // Valid in sloppy mode only, and only when the
+  // --harmony-restrictive-declarations flag is off
   const char* unrestricted_data[] = {
     "do function foo() {} while (0);",
     "for (;false;) function foo() {}",
@@ -7285,16 +7288,28 @@ TEST(FunctionDeclarationError) {
     "for (x in {}) function f() { };",
     "var x; for (x in {}) function foo() {}",
     "with ({}) function f() { };",
+    "do label: function foo() {} while (0);",
+    "for (;false;) label: function foo() {}",
+    "for (var i = 0; i < 1; i++) label: function f() { };",
+    "for (var x in {a: 1}) label: function f() { };",
+    "for (var x in {}) label: function f() { };",
+    "for (var x in {}) label: function foo() {}",
+    "for (x in {a: 1}) label: function f() { };",
+    "for (x in {}) label: function f() { };",
+    "var x; for (x in {}) label: function foo() {}",
+    "with ({}) label: function f() { };",
+    "if (true) label: function f() {}",
+    "if (true) {} else label: function f() {}",
     NULL
   };
+  // Valid only in sloppy mode, with or without
+  // --harmony-restrictive-declarations
   const char* sloppy_data[] = {
     "if (true) function foo() {}",
     "if (false) {} else function f() { };",
     "label: function f() { }",
     "label: if (true) function f() { }",
     "label: if (true) {} else function f() { }",
-    "if (true) label: function f() {}",
-    "if (true) {} else label: function f() {}",
     NULL
   };
   // clang-format on
@@ -7302,6 +7317,7 @@ TEST(FunctionDeclarationError) {
   static const ParserFlag restrictive_flags[] = {
       kAllowHarmonyRestrictiveDeclarations};
 
+  // Nothing parses in strict mode without a SyntaxError
   RunParserSyncTest(strict_context, error_data, kError);
   RunParserSyncTest(strict_context, error_data, kError, NULL, 0,
                     restrictive_flags, arraysize(restrictive_flags));
@@ -7312,6 +7328,7 @@ TEST(FunctionDeclarationError) {
   RunParserSyncTest(strict_context, sloppy_data, kError, NULL, 0,
                     restrictive_flags, arraysize(restrictive_flags));
 
+  // In sloppy mode, some things are successful, depending on the flag
   RunParserSyncTest(sloppy_context, error_data, kError);
   RunParserSyncTest(sloppy_context, error_data, kError, NULL, 0,
                     restrictive_flags, arraysize(restrictive_flags));