Implement ES2015 labelled function declaration restrictions

Implement ES2015 labelled function declaration restrictions

ES#sec-islabelledfunction specifies that labelled function declarations
may not occur as the body of a control flow construct such as an if
statement. This patch implements those restrictions, which also
eliminates a previous case resulting in a DCHECK failure which is now
a SyntaxError.

BUG=chromium:595309
R=adamk
LOG=Y

Committed: https://crrev.com/7f108b655bce12f922b5b2cec6652cefe1d6a245
Cr-Commit-Position: refs/heads/master@{#35049}

[Dan Ehrenberg, 2016-03-18 00:33:30]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 00:33:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808373003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808373003/1

[commit-bot: I haz the power, 2016-03-18 00:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:56:23]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-03-24 01:15:52]

lgtm % style/naming

Sad about the extra param, but it's at least simple to follow.

https://codereview.chromium.org/1808373003/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1808373003/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:2434: AllowLabelledFunctionStatement
allow_labelled_function_statement,
How about "allow_function" for this name (here and elsewhere)?

https://codereview.chromium.org/1808373003/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/1808373003/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:756: AllowLabelledFunctionStatement, bool* ok);
Sadly I think v8 style here is to name the argument, even in a declaration.

[Dan Ehrenberg, 2016-03-24 01:32:32]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-03-24 01:32:32]

Fixed style issues

[Dan Ehrenberg, 2016-03-24 01:32:33]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1808373003/#ps20001
(title: "Fix style")

[commit-bot: I haz the power, 2016-03-24 01:32:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808373003/20001

[commit-bot: I haz the power, 2016-03-24 01:57:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-24 01:59:55]

Description was changed from

==========
Implement ES2015 labelled function declaration restrictions

ES#sec-islabelledfunction specifies that labelled function declarations
may not occur as the body of a control flow construct such as an if
statement. This patch implements those restrictions, which also
eliminates a previous case resulting in a DCHECK failure which is now
a SyntaxError.

BUG=chromium:595309
R=adamk
LOG=Y
==========

to

==========
Implement ES2015 labelled function declaration restrictions

ES#sec-islabelledfunction specifies that labelled function declarations
may not occur as the body of a control flow construct such as an if
statement. This patch implements those restrictions, which also
eliminates a previous case resulting in a DCHECK failure which is now
a SyntaxError.

BUG=chromium:595309
R=adamk
LOG=Y

Committed: https://crrev.com/7f108b655bce12f922b5b2cec6652cefe1d6a245
Cr-Commit-Position: refs/heads/master@{#35049}
==========

[commit-bot: I haz the power, 2016-03-24 01:59:56]

Patchset 2 (id:??) landed as
https://crrev.com/7f108b655bce12f922b5b2cec6652cefe1d6a245
Cr-Commit-Position: refs/heads/master@{#35049}