cc : Make tree synchronization independent of layer tree hierarchy (2)

cc/layers/layer_proto_converter.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_LAYER_PROTO_CONVERTER_H_
 #define CC_LAYERS_LAYER_PROTO_CONVERTER_H_
 
 #include <unordered_map>
 
 #include "base/macros.h"
@@ skipping 17 matching lines @@
 
   // Recursively iterate over the given LayerNode proto and read the structure
   // into a local Layer structure, re-using existing Layers. returns the new
   // root Layer after updating the hierarchy (may be the same as
   // |existing_root|). |existing_root| may be null, which might happen during
   // the first deserialize.
   static scoped_refptr<Layer> DeserializeLayerHierarchy(
       const scoped_refptr<Layer> existing_root,
       const proto::LayerNode& root_node);
 
-  // Starting at |root_layer|, serializes the properties of all the dirty nodes
-  // in the Layer hierarchy. The proto::LayerUpdate will contain all nodes that
-  // either are dirty or have dirty descendants. Only nodes that are dirty will
-  // contain the list of dirty properties.
-  static void SerializeLayerProperties(Layer* root_layer,
+  // Serializes the properties of all the dirty nodes in the Layer hierarchy.
+  // The proto::LayerUpdate will contain all nodes that are dirty.  Only nodes
+  // that are dirty will contain the list of dirty properties.

[ajuma, 2016/03/18 14:33:15]

Since the update only contains dirty nodes now, all nodes will have a list of
dirty properties, right?

Also, this comment should mention that the list of layers needing push
properties is cleared out by this method.

[jaydasika, 2016/03/19 02:17:58]

Done.

+  static void SerializeLayerProperties(LayerTreeHost* host,
                                        proto::LayerUpdate* layer_update);
 
   // Iterate over all updated layers from the LayerUpdate, and update the
   // local Layers. |existing_root| must not be null, as that will make it
   // impossible to find the layer to apply the properties to.
   static void DeserializeLayerProperties(
       Layer* existing_root,
       const proto::LayerUpdate& layer_update);
 
   // Returns the Layer with proto.id() as the Layer id, if it exists in
@@ skipping 16 matching lines @@
   using LayerIdMap = std::unordered_map<int, scoped_refptr<Layer>>;
   // Start at |layer| and recursively add |layer| and all its children and
   // special layers to |layer_id_map|.
   static void RecursivelyFindAllLayers(const scoped_refptr<Layer>& layer,
                                        LayerIdMap* layer_id_map);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_LAYER_PROTO_CONVERTER_H_