Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

Forgot to decouple some statement from DCHECK, which was actually
pointed out by Primiano before. Should be fixed now.

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcermak@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/af6fe5172a632660bb0c2d70b6b7f3bbe08aa284
Cr-Commit-Position: refs/heads/master@{#381892}

[Zhen Wang, 2016-03-17 21:44:12]

Description was changed from

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358

Committed: https://crrev.com/c0e3792f832fc454324dbe35d01079b124b072cd
Cr-Commit-Position: refs/heads/master@{#381783}

patch from issue 1765153002 at patchset 180001
(http://crrev.com/1765153002#ps180001)
==========

to

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358

Committed: https://crrev.com/c0e3792f832fc454324dbe35d01079b124b072cd
Cr-Commit-Position: refs/heads/master@{#381783}

patch from issue 1765153002 at patchset 180001
(http://crrev.com/1765153002#ps180001)
==========

[fgorski, 2016-03-17 23:44:47]

fgorski@chromium.org changed reviewers:
+ fgorski@chromium.org

[fgorski, 2016-03-17 23:44:48]

https://codereview.chromium.org/1808353002/diff/1/base/trace_event/trace_conf...
File base/trace_event/trace_config_unittest.cc (right):

https://codereview.chromium.org/1808353002/diff/1/base/trace_event/trace_conf...
base/trace_event/trace_config_unittest.cc:311:
DCHECK(custom_value->GetAsDictionary(&custom_dict));
this line gets compiled out in release builds.

[Zhen Wang, 2016-03-18 00:00:16]

Description was changed from

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358

Committed: https://crrev.com/c0e3792f832fc454324dbe35d01079b124b072cd
Cr-Commit-Position: refs/heads/master@{#381783}

patch from issue 1765153002 at patchset 180001
(http://crrev.com/1765153002#ps180001)
==========

to

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...
==========

[Zhen Wang, 2016-03-18 00:02:39]

https://codereview.chromium.org/1808353002/diff/1/base/trace_event/trace_conf...
File base/trace_event/trace_config_unittest.cc (right):

https://codereview.chromium.org/1808353002/diff/1/base/trace_event/trace_conf...
base/trace_event/trace_config_unittest.cc:311:
DCHECK(custom_value->GetAsDictionary(&custom_dict));
On 2016/03/17 23:44:48, fgorski wrote:
> this line gets compiled out in release builds.

Thanks! Fixed.

[Zhen Wang, 2016-03-18 00:11:55]

Description was changed from

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...
==========

to

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

Forgot to decouple some statement from DCHECK, which was actually 
pointed out by Primiano before. Should be fixed now.

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...
==========

[Zhen Wang, 2016-03-18 00:40:33]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-03-18 00:41:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808353002/20001

[commit-bot: I haz the power, 2016-03-18 03:11:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 03:11:51]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Zhen Wang, 2016-03-18 04:53:02]

The CQ bit was checked by zhenw@chromium.org

[commit-bot: I haz the power, 2016-03-18 04:53:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808353002/20001

[commit-bot: I haz the power, 2016-03-18 04:59:10]

Description was changed from

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

Forgot to decouple some statement from DCHECK, which was actually 
pointed out by Primiano before. Should be fixed now.

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...
==========

to

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

Forgot to decouple some statement from DCHECK, which was actually 
pointed out by Primiano before. Should be fixed now.

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...
==========

[commit-bot: I haz the power, 2016-03-18 04:59:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 05:00:19]

Description was changed from

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

Forgot to decouple some statement from DCHECK, which was actually 
pointed out by Primiano before. Should be fixed now.

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...
==========

to

==========
Reland - Update DevTools Tracing.Start to accept trace config as a parameter

Original CL: https://crrev.com/1765153002

Forgot to decouple some statement from DCHECK, which was actually
pointed out by Primiano before. Should be fixed now.

--------------------
original description
--------------------

This CL updates Tracing.Start to accept trace config as
a parameter when starting tracing. It is backward compatible
with the old way.

Design doc: https://goo.gl/GxQ23k
BUG=579358
TBR=primiano@chromium.org,caseq@chromium.org,simonhatch@chromium.org,petrcerm...

Committed: https://crrev.com/af6fe5172a632660bb0c2d70b6b7f3bbe08aa284
Cr-Commit-Position: refs/heads/master@{#381892}
==========

[commit-bot: I haz the power, 2016-03-18 05:00:21]

Patchset 2 (id:??) landed as
https://crrev.com/af6fe5172a632660bb0c2d70b6b7f3bbe08aa284
Cr-Commit-Position: refs/heads/master@{#381892}