Gather histogram for received packets indicating losses.

net/quic/quic_connection_logger.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_CONNECTION_LOGGER_H_
 #define NET_QUIC_QUIC_CONNECTION_LOGGER_H_
 
+#include <bitset>
+
 #include "net/base/ip_endpoint.h"
+#include "net/base/network_change_notifier.h"
 #include "net/quic/quic_connection.h"
 #include "net/quic/quic_protocol.h"
 
 namespace net {
 
 class CryptoHandshakeMessage;
 
 // This class is a debug visitor of a QuicConnection which logs
 // events to |net_log|.
 class NET_EXPORT_PRIVATE QuicConnectionLogger
@@ skipping 34 matching lines @@
                                base::StringPiece payload) OVERRIDE;
 
   void OnCryptoHandshakeMessageReceived(
       const CryptoHandshakeMessage& message);
   void OnCryptoHandshakeMessageSent(
       const CryptoHandshakeMessage& message);
   void OnConnectionClosed(QuicErrorCode error, bool from_peer);
   void OnSuccessfulVersionNegotiation(const QuicVersion& version);
 
  private:
+  // Do a factory get for an "Ack_" or "Nack_" style histogram for recording
+  // packet loss stats.
+  base::HistogramBase* GetAckHistogram(const char* ack_or_nack);
+  // At destruction time, this records results of |pacaket_received_| into
+  // histograms for specific connection types.
+  void RecordAckNackHistograms();
+
+  // The number of packets for which status is recorded.
+  static const size_t kMaxPacketStatus = 100;
+
   BoundNetLog net_log_;
   // The last packet sequence number received.
   QuicPacketSequenceNumber last_received_packet_sequence_number_;
   // The largest packet sequence number received.  In case of that a packet is
   // received late, this value will not be updated.
   QuicPacketSequenceNumber largest_received_packet_sequence_number_;
   // The largest packet sequence number which the peer has failed to
   // receive, according to the missing packet set in their ack frames.
   QuicPacketSequenceNumber largest_received_missing_packet_sequence_number_;
   // Number of times that the current received packet sequence number is
   // smaller than the last received packet sequence number.
   size_t out_of_order_recieved_packet_count_;
   // Number of times a truncated ACK frame was sent.
   size_t num_truncated_acks_sent_;
   // Number of times a truncated ACK frame was received.
   size_t num_truncated_acks_received_;
   // The kCADR value provided by the server in ServerHello.
   IPEndPoint client_address_;
+  // Vector of inital packets status' indexed by packet sequence numbers, where
+  // false means never received.  Zero is not a valid packet sequence number, so
+  // that offset is never really used.

[Ryan Hamilton, 2014/03/07 17:47:05]

nit: s/really//

[jar (doing other things), 2014/03/07 18:01:11]

Done.

+  std::bitset<kMaxPacketStatus + 1> packets_received_;
+  // The available type of connection (WiFi, 3G, etc.) when connection was first
+  // used.
+  NetworkChangeNotifier::ConnectionType connection_type_;
   DISALLOW_COPY_AND_ASSIGN(QuicConnectionLogger);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CONNECTION_LOGGER_H_