Issue 18083033: Get rid of place-holder for commit-msg hook.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18083033: Get rid of place-holder for commit-msg hook. (Closed)

Created:
7 years, 5 months ago by szager1

Modified:
7 years, 5 months ago

Reviewers:
Isaac (away), M-A Ruel, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Get rid of place-holder for commit-msg hook. This caused problems for repo-based projects that need to install the standard Change-Id commit-msg hook. With the commit-msg hook gone, we can also reinstate the --template argument to 'git clone'. BUG=235215 R=iannucci@chromium.org, ilevy@chromium.org, maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211464

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
	M	gclient_scm.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	D	git-templates/hooks/commit-msg	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

iannucci

code lgtm, though I'm not very familiar with the requirements of repo

7 years, 5 months ago (2013-07-03 22:07:21 UTC) #2

Isaac (away)

lgtm, should be OK. Note however this didn't affect just repo projects, but any project ...

7 years, 5 months ago (2013-07-08 18:41:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r211464.