Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1808303004: Revert of allow one zero length dash (Closed)

Created:
4 years, 9 months ago by bungeman-skia
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of allow one zero length dash (patchset #8 id:140001 of https://codereview.chromium.org/1805963002/ ) Reason for revert: Causes the dash bench to crash. Example crash: https://build.chromium.org/p/client.skia/builders/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release/builds/5581/steps/nanobench/logs/stdio Original issue's description: > allow one zero length dash > > If the constructed stroke that represents a dash has a > single dash of length zero, and the end cap is square or > round, draw the cap. > > The old code initialized the initial dash length to zero, > making it ambiguous whether the first length is zero or > not. > > R=robertphillips@google.com > BUG=583299 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1805963002 > > Committed: https://skia.googlesource.com/skia/+/5e1a24808415df2748822e8082e21a361362cdfe TBR=robertphillips@google.com,reed@google.com,caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583299 Committed: https://skia.googlesource.com/skia/+/6f0749cfc7f93880bd6b8acfdc61900cda4a81fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -92 lines) Patch
M gm/arcto.cpp View 1 chunk +0 lines, -21 lines 0 comments Download
M gm/dashing.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 5 chunks +10 lines, -4 lines 0 comments Download
M src/utils/SkDashPath.cpp View 4 chunks +39 lines, -50 lines 0 comments Download
M src/utils/SkDashPathPriv.h View 1 chunk +4 lines, -12 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
bungeman-skia
Created Revert of allow one zero length dash
4 years, 9 months ago (2016-03-18 12:10:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808303004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808303004/1
4 years, 9 months ago (2016-03-18 12:10:12 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 12:10:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6f0749cfc7f93880bd6b8acfdc61900cda4a81fe

Powered by Google App Engine
This is Rietveld 408576698