Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 18083030: Fixes source map bug: getLocationMessage was incorrect on file segments (Closed)

Created:
7 years ago by Siggi Cherem (dart-lang)
Modified:
7 years ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes source map bug: getLocationMessage was incorrect on file segments R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=24759

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -43 lines) Patch
M pkg/source_maps/lib/span.dart View 1 4 chunks +35 lines, -23 lines 4 comments Download
M pkg/source_maps/test/span_test.dart View 1 2 3 1 chunk +84 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
this is a fix for a bug I ran into while debugging something else in ...
7 years ago (2013-07-03 21:25:22 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/18083030/diff/6001/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/18083030/diff/6001/pkg/source_maps/lib/span.dart#newcode315 pkg/source_maps/lib/span.dart:315: /// underlying file. This API operates on the ...
7 years ago (2013-07-03 21:58:22 UTC) #2
Siggi Cherem (dart-lang)
thanks https://codereview.chromium.org/18083030/diff/6001/pkg/source_maps/lib/span.dart File pkg/source_maps/lib/span.dart (right): https://codereview.chromium.org/18083030/diff/6001/pkg/source_maps/lib/span.dart#newcode315 pkg/source_maps/lib/span.dart:315: /// underlying file. This API operates on the ...
7 years ago (2013-07-03 22:24:54 UTC) #3
Siggi Cherem (dart-lang)
7 years ago (2013-07-03 22:27:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r24759 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698