Issue 18083023: add charsToGlyphs to SkTypeface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18083023: add charsToGlyphs to SkTypeface (Closed)

Created:
7 years, 5 months ago by reed1

Modified:
7 years, 5 months ago

Reviewers:
bungeman-skia, eae

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

add charsToGlyphs to SkTypeface Will disable new unittest until all backends are implemented. On Mac, new API is 4x faster than old paint one, so next CL I will reimplement the paint calls in terms of the new typeface call. R=eae@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=9860

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+318 lines, -1 line)			Patch
A	bench/CmapBench.cpp	View	1 chunk	+93 lines, -0 lines	0 comments	Download
M	gyp/bench.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkTypeface.h	View	2 chunks	+34 lines, -0 lines	0 comments	Download
M	src/core/SkTypeface.cpp	View	2 chunks	+32 lines, -0 lines	0 comments	Download
M	src/ports/SkFontHost_mac.cpp	View	3 chunks	+59 lines, -0 lines	0 comments	Download
M	tests/PaintTest.cpp	View	2 chunks	+99 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eae

On 2013/07/01 21:04:52, reed1 wrote: LGTM but I'm not too familiar with the code. You'll ...

7 years, 5 months ago (2013-07-01 21:16:22 UTC) #2

reed1

7 years, 5 months ago (2013-07-02 13:56:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r9860 (presubmit successful).

Expand Messages | Collapse Messages