Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: base/message_loop/message_loop.cc

Issue 18083015: Add queued_time_ms trace for events in message loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add queue_duration argument into TRACE_EVENT_FLOW_BEGIN Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/tracked_objects.cc » ('j') | base/tracking_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_loop.cc
diff --git a/base/message_loop/message_loop.cc b/base/message_loop/message_loop.cc
index 9e33a426eb9f1241be625c25aee1a1585898c6fc..b4d72a4461b5335f0c556ec2ab97d61153b77833 100644
--- a/base/message_loop/message_loop.cc
+++ b/base/message_loop/message_loop.cc
@@ -456,8 +456,12 @@ bool MessageLoop::ProcessNextDelayedNonNestableTask() {
}
void MessageLoop::RunTask(const PendingTask& pending_task) {
- TRACE_EVENT_FLOW_END0("task", "MessageLoop::PostTask",
- TRACE_ID_MANGLE(GetTaskTraceID(pending_task, this)));
+ TRACE_EVENT_FLOW_END1("task", "MessageLoop::PostTask",
+ TRACE_ID_MANGLE(GetTaskTraceID(pending_task, this)),
+ "queue_duration",
+ (tracked_objects::TrackedTime::Now() -
jar (doing other things) 2013/07/09 16:50:53 I believe that we get the value of Now() on line 4
Xianzhu 2013/07/09 17:22:43 Done. I had been afraid that sometimes TrackedObj
+ tracked_objects::TrackedTime(pending_task.EffectiveTimePosted()))
+ .InMilliseconds());
TRACE_EVENT2("task", "MessageLoop::RunTask",
"src_file", pending_task.posted_from.file_name(),
"src_func", pending_task.posted_from.function_name());
« no previous file with comments | « no previous file | base/tracked_objects.cc » ('j') | base/tracking_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698