Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2013 The Chromium Authors. All rights reserved. | 1 // Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "base/message_loop/message_loop.h" | 5 #include "base/message_loop/message_loop.h" |
| 6 | 6 |
| 7 #include <algorithm> | 7 #include <algorithm> |
| 8 | 8 |
| 9 #include "base/bind.h" | 9 #include "base/bind.h" |
| 10 #include "base/compiler_specific.h" | 10 #include "base/compiler_specific.h" |
| (...skipping 441 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 452 deferred_non_nestable_work_queue_.pop(); | 452 deferred_non_nestable_work_queue_.pop(); |
| 453 | 453 |
| 454 RunTask(pending_task); | 454 RunTask(pending_task); |
| 455 return true; | 455 return true; |
| 456 } | 456 } |
| 457 | 457 |
| 458 void MessageLoop::RunTask(const PendingTask& pending_task) { | 458 void MessageLoop::RunTask(const PendingTask& pending_task) { |
| 459 TRACE_EVENT_FLOW_END0("task", "MessageLoop::PostTask", | 459 TRACE_EVENT_FLOW_END0("task", "MessageLoop::PostTask", |
| 460 TRACE_ID_MANGLE(GetTaskTraceID(pending_task, this))); | 460 TRACE_ID_MANGLE(GetTaskTraceID(pending_task, this))); |
| 461 TRACE_EVENT2("task", "MessageLoop::RunTask", | 461 TRACE_EVENT2("task", "MessageLoop::RunTask", |
| 462 "src_file", pending_task.posted_from.file_name(), | 462 "src", pending_task.posted_from.ToTraceFormat(), |
| 463 "src_func", pending_task.posted_from.function_name()); | 463 "queued_time_ms", |
| 464 pending_task.DurationSinceExpectedRunTime().InMilliseconds()); | |
|
jar (doing other things)
2013/07/08 17:08:33
Possibly not a big deal... I'm always wary of the
Xianzhu
2013/07/08 18:51:39
Changed DurationSinceExpectedRunTime() to return t
| |
| 465 | |
| 464 DCHECK(nestable_tasks_allowed_); | 466 DCHECK(nestable_tasks_allowed_); |
| 465 // Execute the task and assume the worst: It is probably not reentrant. | 467 // Execute the task and assume the worst: It is probably not reentrant. |
| 466 nestable_tasks_allowed_ = false; | 468 nestable_tasks_allowed_ = false; |
| 467 | 469 |
| 468 // Before running the task, store the program counter where it was posted | 470 // Before running the task, store the program counter where it was posted |
| 469 // and deliberately alias it to ensure it is on the stack if the task | 471 // and deliberately alias it to ensure it is on the stack if the task |
| 470 // crashes. Be careful not to assume that the variable itself will have the | 472 // crashes. Be careful not to assume that the variable itself will have the |
| 471 // expected value when displayed by the optimizer in an optimized build. | 473 // expected value when displayed by the optimizer in an optimized build. |
| 472 // Look at a memory dump of the stack. | 474 // Look at a memory dump of the stack. |
| 473 const void* program_counter = | 475 const void* program_counter = |
| (...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 825 fd, | 827 fd, |
| 826 persistent, | 828 persistent, |
| 827 mode, | 829 mode, |
| 828 controller, | 830 controller, |
| 829 delegate); | 831 delegate); |
| 830 } | 832 } |
| 831 | 833 |
| 832 #endif | 834 #endif |
| 833 | 835 |
| 834 } // namespace base | 836 } // namespace base |
| OLD | NEW |