Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 18083004: MIPS: The check for internalized strings relied on the fact that we had less than 64 distinct Insta… (Closed)

Created:
7 years, 5 months ago by kilvadyb
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: The check for internalized strings relied on the fact that we had less than 64 distinct InstanceTypes. Port r15358 (3af77be) Original commit message: The check for internalized strings relied on the fact that we had less than 64 distinct InstanceTypes. We are hitting that boundary, so this check needs to be more comprehensive. In fact, two bits need to be tested: verify that kNotStringTag isn't set, and that kInternalizedTag is set. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M src/mips/code-stubs-mips.cc View 7 chunks +24 lines, -31 lines 0 comments Download
M src/mips/ic-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 5 months ago (2013-06-27 17:35:01 UTC) #1
kisg
LGTM
7 years, 5 months ago (2013-06-27 18:34:17 UTC) #2
palfia
7 years, 5 months ago (2013-06-27 19:20:33 UTC) #3
Committed as r15368.

Powered by Google App Engine
This is Rietveld 408576698