Implement Vulkan GrBackendObject for textures.

Implement Vulkan GrBackendObject for textures.

BUG=skia:5043
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1808263002

Committed: https://skia.googlesource.com/skia/+/fd359caf0cbdefd759d1c788d72faba3f65a6386

[jvanverth1, 2016-03-17 16:48:33]

Description was changed from

==========
Implement Vulkan GrBackendObject for textures.

BUG=skia:5043
==========

to

==========
Implement Vulkan GrBackendObject for textures.

BUG=skia:5043
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-03-17 16:52:39]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[jvanverth1, 2016-03-17 16:52:39]

jvanverth@google.com changed required reviewers:
+ bsalomon@google.com

[bsalomon, 2016-03-17 17:19:03]

https://codereview.chromium.org/1808263002/diff/20001/src/gpu/vk/GrVkRenderTa...
File src/gpu/vk/GrVkRenderTarget.cpp (right):

https://codereview.chromium.org/1808263002/diff/20001/src/gpu/vk/GrVkRenderTa...
src/gpu/vk/GrVkRenderTarget.cpp:210: SkASSERT(info->fAlloc || kAdopted_LifeCycle
!= lifeCycle);
Seems ok to assert here but should the onWrap**() method in GrVkGpu gracefull
fail before this cons would be called? It is reachable from public facing
methods (SkImage factories). Might be good to have a unit test.

Also, should this be documented with GrVkTextureInfo? (that alloc may be null
iff the texture is wrapped with borrow semantics)

[egdaniel, 2016-03-17 17:23:30]

https://codereview.chromium.org/1808263002/diff/20001/include/gpu/vk/GrVkTypes.h
File include/gpu/vk/GrVkTypes.h (right):

https://codereview.chromium.org/1808263002/diff/20001/include/gpu/vk/GrVkType...
include/gpu/vk/GrVkTypes.h:36: VkImageTiling  fImageTiling;
I wonder if we also will want to know the current layout of the texture

[jvanverth1, 2016-03-18 14:30:00]

https://codereview.chromium.org/1808263002/diff/20001/include/gpu/vk/GrVkTypes.h
File include/gpu/vk/GrVkTypes.h (right):

https://codereview.chromium.org/1808263002/diff/20001/include/gpu/vk/GrVkType...
include/gpu/vk/GrVkTypes.h:36: VkImageTiling  fImageTiling;
On 2016/03/17 17:23:30, egdaniel wrote:
> I wonder if we also will want to know the current layout of the texture

Done.

https://codereview.chromium.org/1808263002/diff/20001/src/gpu/vk/GrVkRenderTa...
File src/gpu/vk/GrVkRenderTarget.cpp (right):

https://codereview.chromium.org/1808263002/diff/20001/src/gpu/vk/GrVkRenderTa...
src/gpu/vk/GrVkRenderTarget.cpp:210: SkASSERT(info->fAlloc || kAdopted_LifeCycle
!= lifeCycle);
On 2016/03/17 17:19:03, bsalomon wrote:
> Seems ok to assert here but should the onWrap**() method in GrVkGpu gracefull
> fail before this cons would be called? It is reachable from public facing
> methods (SkImage factories). Might be good to have a unit test.
> 
> Also, should this be documented with GrVkTextureInfo? (that alloc may be null
> iff the texture is wrapped with borrow semantics)

Done.

[bsalomon, 2016-03-18 15:20:44]

lgtm

https://codereview.chromium.org/1808263002/diff/60001/tests/VkWrapTests.cpp
File tests/VkWrapTests.cpp (right):

https://codereview.chromium.org/1808263002/diff/60001/tests/VkWrapTests.cpp#n...
tests/VkWrapTests.cpp:3: * Copyright 2015 Google Inc.
2016

[jvanverth1, 2016-03-18 18:32:53]

https://codereview.chromium.org/1808263002/diff/60001/tests/VkWrapTests.cpp
File tests/VkWrapTests.cpp (right):

https://codereview.chromium.org/1808263002/diff/60001/tests/VkWrapTests.cpp#n...
tests/VkWrapTests.cpp:3: * Copyright 2015 Google Inc.
On 2016/03/18 15:20:44, bsalomon wrote:
> 2016

Done.

[jvanverth1, 2016-03-18 18:32:57]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-03-18 18:32:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1808263002/#ps80001
(title: "Tweaks")

[commit-bot: I haz the power, 2016-03-18 18:33:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808263002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808263002/80001

[commit-bot: I haz the power, 2016-03-18 18:57:26]

Description was changed from

==========
Implement Vulkan GrBackendObject for textures.

BUG=skia:5043
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Implement Vulkan GrBackendObject for textures.

BUG=skia:5043
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/fd359caf0cbdefd759d1c788d72faba3f65a6386
==========

[commit-bot: I haz the power, 2016-03-18 18:57:28]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/fd359caf0cbdefd759d1c788d72faba3f65a6386