Mojo's WTF dependencies should be set correctly regardless the path depth

Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
Committed: https://crrev.com/05725db3438ca433acc02d136acb49a8cc535375
Cr-Commit-Position: refs/heads/master@{#381751}

[Peter Beverloo, 2016-03-17 16:45:10]

peter@chromium.org changed reviewers:
+ yzshen@chromium.org

[Peter Beverloo, 2016-03-17 16:45:11]

+yzshen

[Peter Beverloo, 2016-03-17 16:45:24]

Description was changed from

==========
Mojo's WTF dependencies should be set correctly regardless the depth

Dependency resolution in gyp uses relative paths, so usage of the
`for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

to

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths, so usage of the
`for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

[Peter Beverloo, 2016-03-17 16:45:58]

Description was changed from

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths, so usage of the
`for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

to

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

[yzshen1, 2016-03-17 16:46:12]

On 2016/03/17 16:45:11, Peter Beverloo wrote:
> +yzshen

LGTM

[yzshen1, 2016-03-17 16:46:58]

+CC Ken for OWNER review.

Thanks for the change.

On Thu, Mar 17, 2016 at 9:45 AM, <peter@chromium.org> wrote:

> Reviewers: yzshen1
> CL: https://codereview.chromium.org/1808253002/
>
> Message:
> +yzshen
>
> Description:
> Mojo's WTF dependencies should be set correctly regardless the depth
>
> Dependency resolution in gyp uses relative paths, so usage of the
> `for_blink` variable fails for any target that doesn't immediately
> live in //mojo. This is different from GN, where the dependency is
> declared absolutely: //mojo/public/cpp/bindings:wtf_support
>
> BUG=583738
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+4, -4 lines):
> M mojo/mojom_bindings_generator.gypi
> M mojo/mojom_bindings_generator_explicit.gypi
>
>
> Index: mojo/mojom_bindings_generator.gypi
> diff --git a/mojo/mojom_bindings_generator.gypi
> b/mojo/mojom_bindings_generator.gypi
> index
>
6518ee4c66e1633d6433980ae3971ec37da76751..bcf98b229e94cf9eebca7df57e63d3ad8ec32a58
> 100644
> --- a/mojo/mojom_bindings_generator.gypi
> +++ b/mojo/mojom_bindings_generator.gypi
> @@ -37,8 +37,8 @@
> '--for_blink',
> ],
> 'wtf_dependencies%': [
> - 'mojo_public.gyp:mojo_cpp_bindings_wtf_support',
> - '../third_party/WebKit/Source/wtf/wtf.gyp:wtf',
> + '<(DEPTH)/mojo/mojo_public.gyp:mojo_cpp_bindings_wtf_support',
> + '<(DEPTH)/third_party/WebKit/Source/wtf/wtf.gyp:wtf',
> ],
> }, {
> 'mojom_generator_wtf_arg%': [],
> Index: mojo/mojom_bindings_generator_explicit.gypi
> diff --git a/mojo/mojom_bindings_generator_explicit.gypi
> b/mojo/mojom_bindings_generator_explicit.gypi
> index
>
0ca10c68347b764c1fd19b60ed27121696eba325..599ee3b4790ba4b0305c6a278d5d4cc0ab126083
> 100644
> --- a/mojo/mojom_bindings_generator_explicit.gypi
> +++ b/mojo/mojom_bindings_generator_explicit.gypi
> @@ -32,8 +32,8 @@
> '--for_blink',
> ],
> 'wtf_dependencies%': [
> - 'mojo_public.gyp:mojo_cpp_bindings_wtf_support',
> - '../third_party/WebKit/Source/wtf/wtf.gyp:wtf',
> + '<(DEPTH)/mojo/mojo_public.gyp:mojo_cpp_bindings_wtf_support',
> + '<(DEPTH)/third_party/WebKit/Source/wtf/wtf.gyp:wtf',
> ],
> }, {
> 'mojom_generator_wtf_arg%': [],
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Beverloo, 2016-03-17 16:53:02]

peter@chromium.org changed reviewers:
+ rockot@chromium.org

[Peter Beverloo, 2016-03-17 16:53:02]

(actually +Ken)

[Ken Rockot(use gerrit already), 2016-03-17 16:54:16]

lgtm

[Peter Beverloo, 2016-03-17 16:55:15]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2016-03-17 16:55:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808253002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808253002/1

[commit-bot: I haz the power, 2016-03-17 18:26:00]

Description was changed from

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

to

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

[commit-bot: I haz the power, 2016-03-17 18:26:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 18:27:11]

Description was changed from

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738
==========

to

==========
Mojo's WTF dependencies should be set correctly regardless the path depth

Dependency resolution in gyp uses relative paths from the target, so usage
of the `for_blink` variable fails for any target that doesn't immediately
live in //mojo. This is different from GN, where the dependency is
declared absolutely: //mojo/public/cpp/bindings:wtf_support

BUG=583738

Committed: https://crrev.com/05725db3438ca433acc02d136acb49a8cc535375
Cr-Commit-Position: refs/heads/master@{#381751}
==========

[commit-bot: I haz the power, 2016-03-17 18:27:12]

Patchset 1 (id:??) landed as
https://crrev.com/05725db3438ca433acc02d136acb49a8cc535375
Cr-Commit-Position: refs/heads/master@{#381751}