Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 1808233003: [mojo-edk] Shutdown a node's bootstrap parent channel outside its lock. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Shutdown a node's bootstrap parent channel outside its lock. On OSX, NodeChannel::ShutDown() calls into NodeController::GetMachPortRelay() which acquires |parent_lock_| and deadlocks due to a recursuve lock acquisition. BUG=582468 Committed: https://crrev.com/86045e737391ccffa0383eaa51c6c2bc858fa0ca Cr-Commit-Position: refs/heads/master@{#381852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M mojo/edk/system/node_controller.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-17 17:20:37 UTC) #2
Ken Rockot(use gerrit already)
lgtm
4 years, 9 months ago (2016-03-18 00:06:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808233003/1
4 years, 9 months ago (2016-03-18 00:11:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 00:48:52 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:49:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86045e737391ccffa0383eaa51c6c2bc858fa0ca
Cr-Commit-Position: refs/heads/master@{#381852}

Powered by Google App Engine
This is Rietveld 408576698