Remove libpeerconnection target from third_party/libjingle

Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=webrtc:4256, 481633
Committed: https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f
Cr-Commit-Position: refs/heads/master@{#383468}

[kjellander_chromium, 2016-03-17 15:08:17]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-17 15:08:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808233002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808233002/1

[commit-bot: I haz the power, 2016-03-17 17:03:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-17 17:03:55]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[kjellander_chromium, 2016-03-17 20:36:54]

Description was changed from

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=481633
==========

to

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=481633
==========

[kjellander_chromium, 2016-03-17 20:36:54]

kjellander@chromium.org changed reviewers:
+ tommi@chromium.org

[kjellander_chromium, 2016-03-17 20:37:54]

kjellander@chromium.org changed reviewers:
+ jochen@chromium.org

[kjellander_chromium, 2016-03-17 20:38:09]

kjellander@chromium.org changed reviewers:
+ sergeyu@chromium.org

[kjellander_chromium, 2016-03-17 20:39:57]

This is part of a step-by-step process to make the Chromium
src/third_party/libjingle/libjingle.gyp similar to the GYP files we have for the
now moved talk/ code that lives in 
src/third_party/webrtc/media
src/third_party/webrtc/p2p
src/third_party/webrtc/pc

When the delta is sufficiently small, I will eliminate the last pieces in
src/third_party/libjingle and remove it entirely, but I want to do careful small
steps towards that.

[tommi (sloooow) - chröme, 2016-03-17 20:49:17]

lgtm

https://codereview.chromium.org/1808233002/diff/1/third_party/libjingle/libji...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/1808233002/diff/1/third_party/libjingle/libji...
third_party/libjingle/libjingle.gyp:373: 
nit: remove

[kjellander_chromium, 2016-03-17 20:55:15]

https://codereview.chromium.org/1808233002/diff/1/third_party/libjingle/libji...
File third_party/libjingle/libjingle.gyp (right):

https://codereview.chromium.org/1808233002/diff/1/third_party/libjingle/libji...
third_party/libjingle/libjingle.gyp:373: 
On 2016/03/17 20:49:17, tommi-chromium wrote:
> nit: remove

Oops, done in PS#2.

[kjellander_chromium, 2016-03-17 20:55:54]

Description was changed from

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=481633
==========

to

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=webrtc:4256,481633
==========

[Sergey Ulanov, 2016-03-17 23:27:47]

lgtm

[kjellander_chromium, 2016-03-21 07:53:43]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 07:53:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808233002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808233002/20001

[commit-bot: I haz the power, 2016-03-21 07:55:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 07:55:48]

Dry run: Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kjellander_chromium, 2016-03-21 19:55:23]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-21 19:55:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808233002/40001

[kjellander_chromium, 2016-03-21 19:56:09]

kjellander@chromium.org changed reviewers:
+ jam@chromium.org

[kjellander_chromium, 2016-03-21 19:56:10]

+jam: can I have rubberstamp for content/*.gyp?

[commit-bot: I haz the power, 2016-03-21 21:14:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-21 21:14:30]

Dry run: Try jobs failed on following builders:
  win_clang_x64_dbg on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang_x64_dbg...)

[Nico, 2016-03-21 21:28:24]

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
/showIncludes /FC
@obj/third_party/libjingle/libjingle_webrtc_common/webrtcmediaengine.obj.rsp /c
../../third_party/webrtc/media/engine/webrtcmediaengine.cc
/Foobj/third_party/libjingle/libjingle_webrtc_common/webrtcmediaengine.obj
/Fdobj/third_party/libjingle/libjingle_webrtc_common_cc.pdb
In file included from
../../third_party/webrtc/media/engine/webrtcmediaengine.cc:11:
In file included from
../../third_party\webrtc/media/engine/webrtcmediaengine.h:17:
In file included from ../../third_party\webrtc/config.h:19:
In file included from ../../third_party\webrtc/common.h:16:
../../third_party\webrtc/base/basictypes.h(18,10) :  error: #include resolved
using non-portable Microsoft search rules as: ../../third_party\webrtc/config.h
[-Werror,-Wmicrosoft-include]
#include "config.h"  // NOLINT
         ^
1 error generated.


This means that there are two config.h headers, and depending on which header
search rules the compiler picks, different files will be picked up. See
https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ...
slide 34-37 (with speaker notes).

[kjellander_chromium, 2016-03-21 21:53:50]

On 2016/03/21 21:28:24, Nico wrote:
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
> ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo
> /showIncludes /FC
> @obj/third_party/libjingle/libjingle_webrtc_common/webrtcmediaengine.obj.rsp
/c
> ../../third_party/webrtc/media/engine/webrtcmediaengine.cc
> /Foobj/third_party/libjingle/libjingle_webrtc_common/webrtcmediaengine.obj
> /Fdobj/third_party/libjingle/libjingle_webrtc_common_cc.pdb
> In file included from
> ../../third_party/webrtc/media/engine/webrtcmediaengine.cc:11:
> In file included from
> ../../third_party\webrtc/media/engine/webrtcmediaengine.h:17:
> In file included from ../../third_party\webrtc/config.h:19:
> In file included from ../../third_party\webrtc/common.h:16:
> ../../third_party\webrtc/base/basictypes.h(18,10) :  error: #include resolved
> using non-portable Microsoft search rules as:
../../third_party\webrtc/config.h
> [-Werror,-Wmicrosoft-include]
> #include "config.h"  // NOLINT
>          ^
> 1 error generated.
> 
> 
> This means that there are two config.h headers, and depending on which header
> search rules the compiler picks, different files will be picked up. See
>
https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ...
> slide 34-37 (with speaker notes).

Thanks for explaining. I guess we should either get rid of these (legacy?)
includes of config.h or just rename the
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc...
header instead.

[jam, 2016-03-22 15:32:04]

lgtm

[jochen (gone - plz use gerrit), 2016-03-24 14:33:18]

lgtm

[tommi (sloooow) - chröme, 2016-03-24 14:43:10]

The CQ bit was checked by tommi@chromium.org

[tommi (sloooow) - chröme, 2016-03-24 14:43:10]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/1808233002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-03-24 14:43:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808233002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808233002/40001

[commit-bot: I haz the power, 2016-03-24 14:45:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 14:45:20]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[kjellander_chromium, 2016-03-26 21:29:50]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-26 21:29:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808233002/60001

[commit-bot: I haz the power, 2016-03-26 22:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 22:34:11]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-03-27 18:25:55]

On 2016/03/26 22:34:11, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

I guess win_clang_x64_dbg is no longer a default trybot (or I'm just lucky with
the experiment this time). I'm adressing the config.h problem in
https://codereview.webrtc.org/1820023004/ anyway, but I will proceed and land
this now.

[kjellander_chromium, 2016-03-27 18:26:02]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-03-27 18:26:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sergeyu@chromium.org, jochen@chromium.org, jam@chromium.org, tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/1808233002/#ps60001
(title: "Rebased again")

[commit-bot: I haz the power, 2016-03-27 18:26:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1808233002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1808233002/60001

[commit-bot: I haz the power, 2016-03-27 18:33:57]

Description was changed from

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=webrtc:4256,481633
==========

to

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=webrtc:4256,481633
==========

[commit-bot: I haz the power, 2016-03-27 18:33:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-27 18:35:08]

Description was changed from

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=webrtc:4256,481633
==========

to

==========
Remove libpeerconnection target from third_party/libjingle

All locations that depended on the target also depended on libjingle_webrtc,
which is where the sources of libpeerconnection were moved.

BUG=webrtc:4256,481633

Committed: https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f
Cr-Commit-Position: refs/heads/master@{#383468}
==========

[commit-bot: I haz the power, 2016-03-27 18:35:10]

Patchset 4 (id:??) landed as
https://crrev.com/696e62e66c1f1d2121f1451501d3066bf2f5ea4f
Cr-Commit-Position: refs/heads/master@{#383468}

[Nico, 2016-03-28 14:15:21]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1834163002/ by thakis@chromium.org.

The reason for reverting is: Broke clang/win gn build
(https://bugs.chromium.org/p/chromium/issues/detail?id=598316), as mentioned in
the review thread in comment 24..