Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1808213004: Add File.renameSync() to virtual file system. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -6 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 4 chunks +30 lines, -2 lines 1 comment Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 3 chunks +50 lines, -4 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-17 19:24:50 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1808213004/diff/1/pkg/analyzer/lib/file_system/memory_file_system.dart File pkg/analyzer/lib/file_system/memory_file_system.dart (right): https://codereview.chromium.org/1808213004/diff/1/pkg/analyzer/lib/file_system/memory_file_system.dart#newcode174 pkg/analyzer/lib/file_system/memory_file_system.dart:174: _pathToWatchers[newPath] = _pathToWatchers.remove(path); Does this need to call ...
4 years, 9 months ago (2016-03-17 19:31:00 UTC) #2
scheglov
4 years, 9 months ago (2016-03-17 19:50:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
561f6f5bed12b930f68ede1346a1b2e3b14d2ad7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698