third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased to ToT again! Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/vr/DEPS ('k') | third_party/WebKit/Source/modules/vr/VRController.h » ('j') | third_party/WebKit/Source/modules/vr/VRController.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp

diff --git a/third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp b/third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp

index aad047a65311b1f2ca510df3663b3f7b409e0bf5..a0dcf4b725bb5ed90989e34a09609dc64ee9c820 100644

--- a/third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp

+++ b/third_party/WebKit/Source/modules/vr/NavigatorVRDevice.cpp

@@ -58,7 +58,8 @@ ScriptPromise NavigatorVRDevice::getVRDevices(ScriptState* scriptState)

return promise;

}

- controller()->getDevices(new VRGetDevicesCallback(resolver, m_hardwareUnits.get()));

+ std::unique_ptr<VRGetDevicesCallback> callback(new VRGetDevicesCallback(resolver, m_hardwareUnits.get()));

+ controller()->getDevices(std::move(callback));

esprehn 2016/05/06 03:14:53 You want to use WTF::wrapUnique here.

RaviKasibhatla 2016/05/06 09:15:49 Done.

return promise;

}