third_party/WebKit/Source/platform/BUILD.gn - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/BUILD.gn

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked as per comments! Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/vr/VRController.cpp ('K') | « third_party/WebKit/Source/modules/vr/VRController.cpp ('k') | third_party/WebKit/Source/platform/DEPS » ('j') | third_party/WebKit/Source/platform/blink_platform.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/BUILD.gn

diff --git a/third_party/WebKit/Source/platform/BUILD.gn b/third_party/WebKit/Source/platform/BUILD.gn

index 830dbc5fd0a1c8834b7fbd03d41fd9819a6a5618..7c1d03ac10dff761ce8c254cbd73ddc81ab8eb91 100644

--- a/third_party/WebKit/Source/platform/BUILD.gn

+++ b/third_party/WebKit/Source/platform/BUILD.gn

@@ -339,6 +339,7 @@ component("platform") {

"//v8",

]

deps = [

+ "//content/common:mojo_bindings",

Yuki 2016/03/22 07:15:03 As you already knew, Blink shouldn't depend on con

RaviKasibhatla 2016/03/23 15:20:50 Done. My bad. I had added when the new location of

"//device/battery:mojo_bindings",

"//mojo/public/c/system:for_component",

"//third_party/WebKit/Source/platform/heap",