content/browser/frame_host/render_frame_host_impl.cc - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased to ToT and fixed the crash in webkit_unit_tests! Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/render_frame_host_impl.cc

diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc

index 24fb489c389ab6732bb56dcc8b1f9d7512ca8dd5..b779221c825e8c1dfa0d1ab050f7d4d8605a63e7 100644

--- a/content/browser/frame_host/render_frame_host_impl.cc

+++ b/content/browser/frame_host/render_frame_host_impl.cc

@@ -1942,7 +1942,8 @@ void RenderFrameHostImpl::RegisterMojoServices() {

*base::CommandLine::ForCurrentProcess();

if (browser_command_line.HasSwitch(switches::kEnableWebVR)) {

- GetServiceRegistry()->AddService(base::Bind(&VRDeviceManager::BindRequest));

+ GetServiceRegistry()->AddService<blink::mojom::VRService>(

dcheng 2016/04/28 19:59:44 Why does this template argument need to be specifi

+ base::Bind(&VRDeviceManager::BindRequest));

}

#endif

« no previous file with comments | « content/browser/DEPS ('k') | content/browser/vr/android/cardboard/cardboard_vr_device.h » ('j') | third_party/WebKit/Source/modules/OWNERS » ('J')