third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked as per new comments. Fixed build errors! Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/mojo/MojoHelper.h ('K') | « third_party/WebKit/Source/platform/mojo/MojoHelper.h ('k') | third_party/WebKit/public/BUILD.gn » ('j') | third_party/WebKit/public/platform/modules/vr/vr_service.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 903e23d883d5d7a47180a65ae5e65ed0b0777fed..32188bf53f6c47864273c2961bb13724451b8ac5 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1489,7 +1489,7 @@ void WebLocalFrameImpl::setCoreFrame(LocalFrame* frame)

if (RuntimeEnabledFeatures::permissionsEnabled())

PermissionController::provideTo(*m_frame, m_client ? m_client->permissionClient() : nullptr);

if (RuntimeEnabledFeatures::webVREnabled())

- VRController::provideTo(*m_frame, m_client ? m_client->webVRClient() : nullptr);

+ VRController::provideTo(*m_frame, m_client ? m_client->serviceRegistry() : nullptr);

if (RuntimeEnabledFeatures::wakeLockEnabled())

ScreenWakeLock::provideTo(*m_frame, m_client ? m_client->serviceRegistry(): nullptr);

if (RuntimeEnabledFeatures::audioOutputDevicesEnabled())