third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked as per new comments. Fixed build errors! Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/vr/VRController.cpp ('K') | « third_party/WebKit/Source/modules/vr/VRController.cpp ('k') | third_party/WebKit/Source/modules/vr/VRTypeConverters.h » ('j') | third_party/WebKit/Source/platform/mojo/MojoHelper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

diff --git a/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h b/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

index ef0bff9d04f5ab20519ff80eec77180d2b9f0b60..ccbc2f8d78427f2088bf99201ca90bb6cca0aaff 100644

--- a/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

+++ b/third_party/WebKit/Source/modules/vr/VRGetDevicesCallback.h

@@ -6,14 +6,17 @@

#define VRGetDevicesCallback_h

#include "platform/heap/Handle.h"

-#include "public/platform/modules/vr/WebVRClient.h"

+#include "public/platform/WebCallbacks.h"

+#include "public/platform/WebVector.h"

+#include "public/platform/modules/vr/WebVR.h"

namespace blink {

class VRHardwareUnitCollection;

class ScriptPromiseResolver;

-class WebVRClient;

+// Success and failure callbacks for getDevices.

+using WebVRGetDevicesCallback = WebCallbacks<const WebVector<WebVRDevice>&, void>;

class VRGetDevicesCallback final : public WebVRGetDevicesCallback {

USING_FAST_MALLOC(VRGetDevicesCallback);

public: