third_party/WebKit/Source/modules/OWNERS - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Side by Side Diff: third_party/WebKit/Source/modules/OWNERS

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased to ToT and fixed the crash in webkit_unit_tests! Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « third_party/WebKit/Source/modules/BUILD.gn ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | third_party/WebKit/Source/modules/vr/VRController.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 haraken@chromium.org	1 haraken@chromium.org

2 mkwst@chromium.org	2 mkwst@chromium.org

3 mlamouri@chromium.org	3 mlamouri@chromium.org

4	4

5 # Reviewer for inspector-related code:	5 # Reviewer for inspector-related code:

6 pfeldman@chromium.org	6 pfeldman@chromium.org

7	7

8 per-file modules.gypi=*	8 per-file modules.gypi=*

	9

	10 # Changes to Mojo interfaces require a security review to avoid

	11 # introducing new sandbox escapes.
	haraken 2016/04/28 14:50:03 Can we make this change in a separate CL? Can we make this change in a separate CL? esprehn 2016/04/28 15:19:28 This change probably wants to be higher up too, pr Show quoted text On 2016/04/28 at 14:50:03, haraken wrote: > Can we make this change in a separate CL? This change probably wants to be higher up too, probably in the top level owners. dcheng 2016/04/28 17:27:19 This should just go in platform/modules/vr for now Show quoted text On 2016/04/28 at 15:19:28, esprehn wrote: > On 2016/04/28 at 14:50:03, haraken wrote: > > Can we make this change in a separate CL? > > This change probably wants to be higher up too, probably in the top level owners. This should just go in platform/modules/vr for now. I'm working on getting these rules to work recursively, but there's a problem that we need something like CSS's !important as well (since we want to prevent child rules from applying). RaviKasibhatla 2016/04/28 18:08:33 So, should I add this change to WebKit/public/plat Show quoted text On 2016/04/28 17:27:19, dcheng wrote: > On 2016/04/28 at 15:19:28, esprehn wrote: > > On 2016/04/28 at 14:50:03, haraken wrote: > > > Can we make this change in a separate CL? > > > > This change probably wants to be higher up too, probably in the top level > owners. > > This should just go in platform/modules/vr for now. > > I'm working on getting these rules to work recursively, but there's a problem > that we need something like CSS's !important as well (since we want to prevent > child rules from applying). So, should I add this change to WebKit/public/platform/modules/vr/OWNERS or defer any change to OWNERS to a separate CL? haraken 2016/04/28 19:16:15 Let's follow dcheng's comment. Show quoted text On 2016/04/28 18:08:33, RaviKasibhatla wrote: > On 2016/04/28 17:27:19, dcheng wrote: > > On 2016/04/28 at 15:19:28, esprehn wrote: > > > On 2016/04/28 at 14:50:03, haraken wrote: > > > > Can we make this change in a separate CL? > > > > > > This change probably wants to be higher up too, probably in the top level > > owners. > > > > This should just go in platform/modules/vr for now. > > > > I'm working on getting these rules to work recursively, but there's a problem > > that we need something like CSS's !important as well (since we want to prevent > > child rules from applying). > > So, should I add this change to WebKit/public/platform/modules/vr/OWNERS or > defer any change to OWNERS to a separate CL? Let's follow dcheng's comment. RaviKasibhatla 2016/05/03 14:34:21 Done. Show quoted text On 2016/04/28 19:16:15, haraken wrote: > On 2016/04/28 18:08:33, RaviKasibhatla wrote: > > On 2016/04/28 17:27:19, dcheng wrote: > > > On 2016/04/28 at 15:19:28, esprehn wrote: > > > > On 2016/04/28 at 14:50:03, haraken wrote: > > > > > Can we make this change in a separate CL? > > > > > > > > This change probably wants to be higher up too, probably in the top level > > > owners. > > > > > > This should just go in platform/modules/vr for now. > > > > > > I'm working on getting these rules to work recursively, but there's a > problem > > > that we need something like CSS's !important as well (since we want to > prevent > > > child rules from applying). > > > > So, should I add this change to WebKit/public/platform/modules/vr/OWNERS or > > defer any change to OWNERS to a separate CL? > > Let's follow dcheng's comment. Done.
	12 per-file *.mojom=set noparent

	13 per-file *.mojom=dcheng@chromium.org

	14 per-file *.mojom=inferno@chromium.org

	15 per-file *.mojom=jln@chromium.org

	16 per-file *.mojom=jschuh@chromium.org

	17 per-file *.mojom=kenrb@chromium.org

	18 per-file *.mojom=mkwst@chromium.org

	19 per-file *.mojom=nasko@chromium.org

	20 per-file *.mojom=palmer@chromium.org

	21 per-file *.mojom=tsepez@chromium.org

	22 per-file *.mojom=wfh@chromium.org

	23

OLD	NEW