third_party/WebKit/public/platform/modules/vr/vr_service.mojom - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/platform/modules/vr/vr_service.mojom

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked as per new comments. Fixed build errors! Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/mojo/MojoHelper.h ('K') | « third_party/WebKit/public/platform/modules/vr/WebVRClient.h ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module content.mojom;	5 module blink.mojom;
	dcheng 2016/04/27 00:09:29 Btw, let's make sure this file has noparent IPC OW Btw, let's make sure this file has noparent IPC OWNERS rules like the ones in //content/common. Thanks! RaviKasibhatla 2016/04/27 14:33:49 Sorry, but I am not clear. content/common specifie Show quoted text On 2016/04/27 00:09:29, dcheng wrote: > Btw, let's make sure this file has noparent IPC OWNERS rules like the ones in > //content/common. Thanks! Sorry, but I am not clear. content/common specified per-file owner for mojom files removing the parent owners list. Did you meant that we need to have same model here? i.e. I should maintain the same per-file owners list in WebKit/public/platform/modules/vr/OWNERS - as present in content/common.
6	6

7 struct VRVector3 {	7 struct VRVector3 {

8 float x;	8 float x;

9 float y;	9 float y;

10 float z;	10 float z;

11 };	11 };

12	12

13 struct VRVector4 {	13 struct VRVector4 {

14 float x;	14 float x;

15 float y;	15 float y;

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 uint32 index;	64 uint32 index;

65 string deviceName;	65 string deviceName;

66 VRHMDInfo? hmdInfo;	66 VRHMDInfo? hmdInfo;

67 };	67 };

68	68

69 interface VRService {	69 interface VRService {

70 GetDevices() => (array<VRDeviceInfo> devices);	70 GetDevices() => (array<VRDeviceInfo> devices);

71 GetSensorState(uint32 index) => (VRSensorState state);	71 GetSensorState(uint32 index) => (VRSensorState state);

72 ResetSensor(uint32 index);	72 ResetSensor(uint32 index);

73 };	73 };

OLD	NEW