third_party/WebKit/Source/modules/DEPS - Issue 1808203005: [OnionSoup] Moving VR service from content to Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/DEPS

Issue 1808203005: [OnionSoup] Moving VR service from content to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked as per new comments. Fixed build errors! Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/renderer/vr/vr_type_converters.cc ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | third_party/WebKit/Source/modules/vr/VRController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+bindings",	2 "+bindings",

3 "+core",	3 "+core",

4 "+heap",	4 "+heap",

5 "+modules",	5 "+modules",

6 "+platform",	6 "+platform",

7 "+public/platform",	7 "+public/platform",

8 "+skia/ext",	8 "+skia/ext",

9 "-web",	9 "-web",

	10 "+mojo/public",
	haraken 2016/04/27 06:51:06 I'm curious why we need to add this dependency now I'm curious why we need to add this dependency now. We've already used Mojo in modules/ without adding the dependency. RaviKasibhatla 2016/04/27 14:33:49 The other place that I noticed mojo/public was inc Show quoted text On 2016/04/27 06:51:06, haraken wrote: > > I'm curious why we need to add this dependency now. We've already used Mojo in > modules/ without adding the dependency. > The other place that I noticed mojo/public was included was in modules/payments. A separate DEPS was added in modules/payments to filter the newly included headers. I have now done the same and added a new DEPS in modules/vr to filter the mojo/public inclusion.
10 ]	11 ]

OLD	NEW