webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc - Issue 18082: Improve scrolling performance when there are many windowed plugins in a page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc

Issue 18082: Improve scrolling performance when there are many windowed plugins in a page.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Call DestroyWindow on the right thread & ensure NPP_SetWindow is called right away Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc

===================================================================

--- webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc (revision 8043)

+++ webkit/glue/plugins/test/plugin_npobject_lifetime_test.cc (working copy)

@@ -113,9 +113,6 @@

}

NPError NPObjectDeletePluginInNPN_Evaluate::SetWindow(NPWindow* np_window) {

- if (!::IsWindowVisible(reinterpret_cast<HWND>(np_window->window)))

- return NPERR_NO_ERROR;

HWND window_handle = reinterpret_cast<HWND>(np_window->window);

// We setup a timerproc to invoke NPN_Evaluate to destroy this plugin

// instance. This is to ensure that we don't destroy the plugin instance

« chrome/common/plugin_messages_internal.h ('K') | « chrome/renderer/webplugin_delegate_proxy.cc ('k') | webkit/glue/plugins/webplugin_delegate_impl.h » ('j') | no next file with comments »