Improve scrolling performance when there are many windowed plugins in a page....

webkit/glue/webplugin_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "base/compiler_specific.h"
 #include "build/build_config.h"
 
 MSVC_PUSH_WARNING_LEVEL(0);
@@ skipping 116 matching lines @@
 }
 
 #if USE(JSC)
 bool WebPluginContainer::isPluginView() const { 
   return true; 
 }
 #endif
 
 
 void WebPluginContainer::setFrameRect(const WebCore::IntRect& rect) {
+  // WebKit calls move every time it paints (see RenderWidget::paint).  No need
+  // to do expensive operations if we didn't actually move.
+  if (rect == frameRect())
+    return;
+
   WebCore::Widget::setFrameRect(rect);
   impl_->setFrameRect(rect);
 }
 
 void WebPluginContainer::paint(WebCore::GraphicsContext* gc,
                                const WebCore::IntRect& damage_rect) {
   // In theory, we should call impl_->print(gc); when
   // impl_->webframe_->printing() is true but it still has placement issues so
   // keep that code off for now.
   impl_->paint(gc, damage_rect);
@@ skipping 12 matching lines @@
 }
 
 void WebPluginContainer::setFocus() {
   WebCore::Widget::setFocus();
   impl_->setFocus();
 }
 
 void WebPluginContainer::show() {
   // We don't want to force a geometry update when the plugin widget is
   // already visible as this involves a geometry update which may lead
-  // to unnecessary window moves in the plugin process. The only case
-  // where this does not apply is if the force_geometry_update_ flag
-  // is set, which occurs when a plugin is created and does not have
-  // a parent. We can send out geometry updates only when the plugin
-  // widget has a parent.
-  if (!impl_->visible_ || impl_->force_geometry_update_) {
+  // to unnecessary window moves in the plugin process.
+  if (!impl_->visible_) {
     impl_->show();
     WebCore::Widget::show();
     // This is to force an updategeometry call to the plugin process
     // where the plugin window can be hidden or shown.
     frameRectsChanged();
   }
 }
 
 void WebPluginContainer::hide() {
-  // Please refer to WebPluginContainer::show for the reasoning behind
-  // the if check below.
-  if (impl_->visible_ || impl_->force_geometry_update_) {
+  if (impl_->visible_) {
     impl_->hide();
     WebCore::Widget::hide();
     // This is to force an updategeometry call to the plugin process
     // where the plugin window can be hidden or shown.
     frameRectsChanged();
   }
 }
 
 void WebPluginContainer::handleEvent(WebCore::Event* event) {
   impl_->handleEvent(event);
@@ skipping 12 matching lines @@
 // webkit is ignored. This function is called when the plugin eventually
 // gets a parent.
 void WebPluginContainer::setParentVisible(bool visible) {
   WebCore::Widget::setParentVisible(visible);
   if (visible)
     show();
   else
     hide();
 }
 
+// We override this function so that if the plugin is windowed, we can call
+// NPP_SetWindow at the first possible moment.  This ensures that NPP_SetWindow
+// is called before the manual load data is sent to a plugin.  If this order is
+// reversed, Flash won't load videos.
+void WebPluginContainer::setParent(WebCore::ScrollView* view) {
+  WebCore::Widget::setParent(view);
+  if (view) {    
+    impl_->setFrameRect(frameRect());
+    impl_->delegate_->FlushGeometryUpdates();
+  }
+}
+
 void WebPluginContainer::windowCutoutRects(const WebCore::IntRect& bounds,
                                            WTF::Vector<WebCore::IntRect>*
                                            cutouts) const {
   impl_->windowCutoutRects(bounds, cutouts);
 }
 
 void WebPluginContainer::didReceiveResponse(
     const WebCore::ResourceResponse& response) {
-
   set_ignore_response_error(false);
 
   HttpResponseInfo http_response_info;
   ReadHttpResponseInfo(response, &http_response_info);
 
   impl_->delegate_->DidReceiveManualResponse(
       http_response_info.url,
       base::SysWideToNativeMB(http_response_info.mime_type),
       base::SysWideToNativeMB(impl_->GetAllHeaders(response)),
       http_response_info.expected_length,
@@ skipping 70 matching lines @@
                              bool load_manually,
                              const std::string& mime_type,
                              int arg_count,
                              char** arg_names,
                              char** arg_values)
     : windowless_(false),
       window_(NULL),
       element_(element),
       webframe_(webframe),
       delegate_(delegate),
-      force_geometry_update_(false),
       visible_(false),
-      received_first_paint_notification_(false),
       widget_(NULL),
       plugin_url_(plugin_url),
       load_manually_(load_manually),
       first_geometry_update_(true),
       mime_type_(mime_type) {
 
   ArrayToVector(arg_count, arg_names, &arg_names_);
   ArrayToVector(arg_count, arg_values, &arg_values_);
 }
 
@@ skipping 296 matching lines @@
           WebCore::IntPoint point = roundedIntPoint(ro->localToAbsolute());
           WebCore::IntSize size(ro->width(), ro->height());
           cutouts->append(WebCore::IntRect(point, size));
         }
       }
     }
   }
 }
 
 void WebPluginImpl::setFrameRect(const WebCore::IntRect& rect) {
+  if (!parent())
+    return;
+
   // Compute a new position and clip rect for ourselves relative to the
   // containing window.  We ask our delegate to reposition us accordingly.
-
-  // When the plugin is loaded we don't have a parent frame yet. We need
-  // to force the plugin window to get created in the plugin process,
-  // when the plugin widget position is updated. This occurs just after
-  // the plugin is loaded (See http://b/issue?id=892174).
-  if (!parent()) {
-    force_geometry_update_ = true;
-    return;
-  }
-
   WebCore::Frame* frame = element_->document()->frame();
   WebFrameImpl* webframe = WebFrameImpl::FromFrame(frame);
   WebViewImpl* webview = webframe->webview_impl();
   // It is valid for this function to be invoked in code paths where the
   // the webview is closed.
   if (!webview->delegate()) {
     return;
   }
 
   WebCore::IntRect window_rect;
   WebCore::IntRect clip_rect;
   std::vector<gfx::Rect> cutout_rects;
   CalculateBounds(rect, &window_rect, &clip_rect, &cutout_rects);
 
-  if (window_ && received_first_paint_notification_) {
+  delegate_->UpdateGeometry(
+      webkit_glue::FromIntRect(window_rect),
+      webkit_glue::FromIntRect(clip_rect));
+
+  if (window_) {
     // Let the WebViewDelegate know that the plugin window needs to be moved,
     // so that all the HWNDs are moved together.
     WebPluginGeometry move;
     move.window = window_;
     move.window_rect = webkit_glue::FromIntRect(window_rect);
     move.clip_rect = webkit_glue::FromIntRect(clip_rect);
     move.cutout_rects = cutout_rects;
     move.visible = visible_;
 
     webview->delegate()->DidMove(webview, move);
   }
 
-  delegate_->UpdateGeometry(
-      webkit_glue::FromIntRect(window_rect),
-      webkit_glue::FromIntRect(clip_rect), cutout_rects,
-      windowless_ || received_first_paint_notification_ ? visible_ : false);
-
-  // delegate_ can go away as a result of above call, so check it first.
-  if (force_geometry_update_ && delegate_) {
-    force_geometry_update_ = false;
-    delegate_->FlushGeometryUpdates();
-  }
-
   // Initiate a download on the plugin url. This should be done for the
   // first update geometry sequence.
   if (first_geometry_update_) {
     first_geometry_update_ = false;
     // An empty url corresponds to an EMBED tag with no src attribute.
     if (!load_manually_ && plugin_url_.is_valid()) {
       HandleURLRequestInternal("GET", false, NULL, 0, NULL, false, false,
                                plugin_url_.spec().c_str(), NULL, false,
                                false);
     }
   }
 }
 
 void WebPluginImpl::paint(WebCore::GraphicsContext* gc,
                           const WebCore::IntRect& damage_rect) {
   if (gc->paintingDisabled())
     return;
 
   if (!parent())
     return;
 
   // Don't paint anything if the plugin doesn't intersect the damage rect.
   if (!widget_->frameRect().intersects(damage_rect))
     return;
 
-  // A windowed plugin starts out by being invisible regardless of the style
-  // which webkit tells us. The paint notification from webkit indicates that
-  // the plugin widget is being shown and we need to make sure that
-  // it becomes visible.
-  // Please refer to https://bugs.webkit.org/show_bug.cgi?id=18901 for more
-  // details on this issue.
-  // TODO(iyengar): Remove this hack when this issue is fixed in webkit.
-  if (!received_first_paint_notification_) {
-    received_first_paint_notification_ = true;
-
-    if (!windowless_) {
-      WebCore::IntRect window_rect;
-      WebCore::IntRect clip_rect;
-      std::vector<gfx::Rect> cutout_rects;
-
-      CalculateBounds(widget_->frameRect(), &window_rect, &clip_rect,
-                      &cutout_rects);
-
-      delegate_->UpdateGeometry(webkit_glue::FromIntRect(window_rect),
-                                webkit_glue::FromIntRect(clip_rect),
-                                cutout_rects, visible_);
-      delegate_->FlushGeometryUpdates();
-    }
-  }
-
   gc->save();
 
   DCHECK(parent()->isFrameView());
   WebCore::FrameView* view = static_cast<WebCore::FrameView*>(parent());
 
   // The plugin is positioned in window coordinates, so it needs to be painted
   // in window coordinates.
   WebCore::IntPoint origin = view->windowToContents(WebCore::IntPoint(0, 0));
   gc->translate(static_cast<float>(origin.x()),
                 static_cast<float>(origin.y()));
@@ skipping 693 matching lines @@
     client_index = clients_.erase(client_index);
     if (resource_client)
       resource_client->DidFail();
   }
 
   // This needs to be called now and not in the destructor since the
   // webframe_ might not be valid anymore.
   webframe_->set_plugin_delegate(NULL);
   webframe_ = NULL;
 }