Improve scrolling performance when there are many windowed plugins in a page....

webkit/glue/plugins/webplugin_delegate_impl.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/plugins/webplugin_delegate_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "base/file_util.h"
 #include "base/message_loop.h"
-#include "base/gfx/gdi_util.h"
-#include "base/gfx/point.h"
 #include "base/stats_counters.h"
 #include "base/string_util.h"
 #include "webkit/default_plugin/plugin_impl.h"
 #include "webkit/glue/glue_util.h"
 #include "webkit/glue/webplugin.h"
 #include "webkit/glue/plugins/plugin_instance.h"
 #include "webkit/glue/plugins/plugin_lib.h"
 #include "webkit/glue/plugins/plugin_list.h"
 #include "webkit/glue/plugins/plugin_stream_url.h"
 #include "webkit/glue/webkit_glue.h"
@@ skipping 102 matching lines @@
       instance_(instance),
       quirks_(0),
       plugin_(NULL),
       windowless_(false),
       windowed_handle_(NULL),
       windowed_did_set_window_(false),
       windowless_needs_set_window_(true),
       plugin_wnd_proc_(NULL),
       last_message_(0),
       is_calling_wndproc(false),
-      initial_plugin_resize_done_(false),
       dummy_window_for_activation_(NULL),
       handle_event_message_filter_hook_(NULL),
       handle_event_pump_messages_event_(NULL),
       handle_event_depth_(0),
       user_gesture_message_posted_(false),
 #pragma warning(suppress: 4355)  // can use this
       user_gesture_msg_factory_(this),
       plugin_module_handle_(NULL) {
   memset(&window_, 0, sizeof(window_));
 
@@ skipping 167 matching lines @@
         }
       }
     }
 
     instance_ = 0;
   }
 }
 
 void WebPluginDelegateImpl::UpdateGeometry(
     const gfx::Rect& window_rect,
-    const gfx::Rect& clip_rect,
-    const std::vector<gfx::Rect>& cutout_rects,
-    bool visible) {
+    const gfx::Rect& clip_rect) {
   if (windowless_) {
     WindowlessUpdateGeometry(window_rect, clip_rect);
   } else {
-    WindowedUpdateGeometry(window_rect, clip_rect, cutout_rects, visible);
+    WindowedUpdateGeometry(window_rect, clip_rect);
   }
 }
 
 void WebPluginDelegateImpl::Paint(HDC hdc, const gfx::Rect& rect) {
   if (windowless_)
     WindowlessPaint(hdc, rect);
 }
 
 void WebPluginDelegateImpl::Print(HDC hdc) {
   // Disabling the call to NPP_Print as it causes a crash in
@@ skipping 28 matching lines @@
                                                  bool success,
                                                  bool notify_needed,
                                                  int notify_data) {
   instance()->SendJavaScriptStream(url, result, success, notify_needed,
                                    notify_data);
 }
 
 void WebPluginDelegateImpl::DidReceiveManualResponse(
     const std::string& url, const std::string& mime_type,
     const std::string& headers, uint32 expected_length, uint32 last_modified) {
+  if (!windowless_) {
+    // Calling NPP_WriteReady before NPP_SetWindow causes movies to not load in
+    // Flash.  See http://b/issue?id=892174.
+    DCHECK(windowed_did_set_window_);
+  }
+
   instance()->DidReceiveManualResponse(url, mime_type, headers,
                                        expected_length, last_modified);
 }
 
 void WebPluginDelegateImpl::DidReceiveManualData(const char* buffer,
                                                  int length) {
   instance()->DidReceiveManualData(buffer, length);
 }
 
 void WebPluginDelegateImpl::DidFinishManualLoading() {
@@ skipping 11 matching lines @@
 void WebPluginDelegateImpl::InstallMissingPlugin() {
   NPEvent evt;
   evt.event = PluginInstallerImpl::kInstallMissingPluginMessage;
   evt.lParam = 0;
   evt.wParam = 0;
   instance()->NPP_HandleEvent(&evt);
 }
 
 void WebPluginDelegateImpl::WindowedUpdateGeometry(
     const gfx::Rect& window_rect,
-    const gfx::Rect& clip_rect,
-    const std::vector<gfx::Rect>& cutout_rects,
-    bool visible) {
-  if (WindowedReposition(window_rect, clip_rect, cutout_rects, visible) ||
+    const gfx::Rect& clip_rect) {
+  if (WindowedReposition(window_rect, clip_rect) ||
       !windowed_did_set_window_) {
     // Let the plugin know that it has been moved
     WindowedSetWindow();
   }
 }
 
 bool WebPluginDelegateImpl::WindowedCreatePlugin() {
   DCHECK(!windowed_handle_);
 
   RegisterNativeWindowClass();
@@ skipping 231 matching lines @@
       reinterpret_cast<LPARAM>(
       &WebPluginDelegateImpl::FlashWindowlessWndProc))) {
     // Log that this happened.  Flash will still work; it just means the
     // throttle isn't installed (and Flash will use more CPU).
     NOTREACHED();
     LOG(ERROR) << "Failed to wrap all windowless Flash windows";
   }
   return true;
 }
 
-void WebPluginDelegateImpl::MoveWindow(
-    HWND window,
-    const gfx::Rect& window_rect,
-    const gfx::Rect& clip_rect,
-    const std::vector<gfx::Rect>& cutout_rects,
-    bool visible) {
-  HRGN hrgn = ::CreateRectRgn(clip_rect.x(),
-                              clip_rect.y(),
-                              clip_rect.right(),
-                              clip_rect.bottom());
-  gfx::SubtractRectanglesFromRegion(hrgn, cutout_rects);
-
-  // Note: System will own the hrgn after we call SetWindowRgn,
-  // so we don't need to call DeleteObject(hrgn)
-  ::SetWindowRgn(window, hrgn, FALSE);
-
-  unsigned long flags = 0;
-  if (visible)
-    flags |= SWP_SHOWWINDOW;
-  else
-    flags |= SWP_HIDEWINDOW;
-
-  ::SetWindowPos(window,
-                 NULL,
-                 window_rect.x(),
-                 window_rect.y(),
-                 window_rect.width(),
-                 window_rect.height(),
-                 flags);
-}
-
 bool WebPluginDelegateImpl::WindowedReposition(
     const gfx::Rect& window_rect,
-    const gfx::Rect& clip_rect,
-    const std::vector<gfx::Rect>& cutout_rects,
-    bool visible) {
+    const gfx::Rect& clip_rect) {
   if (!windowed_handle_) {
     NOTREACHED();
     return false;
   }
 
-  if (window_rect_ == window_rect && clip_rect_ == clip_rect &&
-      cutout_rects == cutout_rects_ &&
-      initial_plugin_resize_done_)
+  if (window_rect_ == window_rect && clip_rect_ == clip_rect)
     return false;
 
+  // Clipping is handled by WebPlugin.
+  if (window_rect.size() != window_rect_.size()) {
+    ::SetWindowPos(windowed_handle_,
+                   NULL,
+                   0,
+                   0,
+                   window_rect.width(),
+                   window_rect.height(),
+                   SWP_SHOWWINDOW);
+  }
+
   window_rect_ = window_rect;
   clip_rect_ = clip_rect;
-  cutout_rects_ = cutout_rects;
 
-  if (!initial_plugin_resize_done_) {
-    // We need to ensure that the plugin process continues to reposition
-    // the plugin window until we receive an indication that it is now visible.
-    // Subsequent repositions will be done by the browser.
-    if (visible)
-      initial_plugin_resize_done_ = true;
-    // We created the window with 0 width and height since we didn't know it
-    // at the time.  Now that we know the geometry, we we can update its size
-    // since the browser only calls SetWindowPos when scrolling occurs.
-    MoveWindow(windowed_handle_, window_rect, clip_rect, cutout_rects, visible);
-    // Ensure that the entire window gets repainted.
-    ::InvalidateRect(windowed_handle_, NULL, FALSE);
-  }
+  // Ensure that the entire window gets repainted.
+  ::InvalidateRect(windowed_handle_, NULL, FALSE);
 
   return true;
 }
 
 void WebPluginDelegateImpl::WindowedSetWindow() {
   if (!instance_)
     return;
 
   if (!windowed_handle_) {
     NOTREACHED();
@@ skipping 428 matching lines @@
 
   // It is ok to pass NULL here to GetCursor as we are not looking for cursor
   // types defined by Webkit.
   HCURSOR previous_cursor =
       current_plugin_instance_->current_windowless_cursor_.GetCursor(NULL);
 
   current_plugin_instance_->current_windowless_cursor_.InitFromExternalCursor(
       cursor);
   return previous_cursor;
 }