Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tests/compiler/dart2js/serialization_test.dart

Issue 1808133002: Revert "Use JS backend in serialization_analysis_test" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/serialization_analysis_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/serialization_test.dart
diff --git a/tests/compiler/dart2js/serialization_test.dart b/tests/compiler/dart2js/serialization_test.dart
index 9985399579ba7c25561d55f8cf8edf558904256b..c913a3cf5ad7daa3e60dc60c9fff62a35f73ee93 100644
--- a/tests/compiler/dart2js/serialization_test.dart
+++ b/tests/compiler/dart2js/serialization_test.dart
@@ -15,9 +15,9 @@ import 'package:compiler/src/diagnostics/invariant.dart';
import 'package:compiler/src/elements/elements.dart';
import 'package:compiler/src/elements/visitor.dart';
import 'package:compiler/src/ordered_typeset.dart';
-import 'package:compiler/src/serialization/element_serialization.dart';
-import 'package:compiler/src/serialization/json_serializer.dart';
import 'package:compiler/src/serialization/serialization.dart';
+import 'package:compiler/src/serialization/json_serializer.dart';
+import 'package:compiler/src/tree/tree.dart';
main(List<String> arguments) {
// Ensure that we can print out constant expressions.
@@ -472,28 +472,41 @@ class ElementPropertyEquivalence extends BaseElementVisitor<dynamic, Element> {
element1.libraryName, element2.libraryName);
visitMembers(element1, element2);
visit(element1.entryCompilationUnit, element2.entryCompilationUnit);
-
checkElementLists(
element1, element2, 'compilationUnits',
- LibrarySerializer.getCompilationUnits(element1),
- LibrarySerializer.getCompilationUnits(element2));
+ element1.compilationUnits.toList(),
+ element2.compilationUnits.toList());
checkElementListIdentities(
- element1, element2, 'imports',
- LibrarySerializer.getImports(element1),
- LibrarySerializer.getImports(element2));
+ element1, element2, 'imports', element1.imports, element2.imports);
checkElementListIdentities(
element1, element2, 'exports', element1.exports, element2.exports);
+ List<Element> imports1 = <Element>[];
+ List<Element> imports2 = <Element>[];
+ element1.forEachImport((Element import) {
+ if (import.isAmbiguous) return;
+ imports1.add(import);
+ });
+ element2.forEachImport((Element import) {
+ if (import.isAmbiguous) return;
+ imports2.add(import);
+ });
checkElementListIdentities(
- element1, element2, 'importScope',
- LibrarySerializer.getImportedElements(element1),
- LibrarySerializer.getImportedElements(element2));
+ element1, element2, 'importScope', imports1, imports2);
+ List<Element> exports1 = <Element>[];
+ List<Element> exports2 = <Element>[];
+ element1.forEachExport((Element export) {
+ if (export.isAmbiguous) return;
+ exports1.add(export);
+ });
+ element2.forEachExport((Element export) {
+ if (export.isAmbiguous) return;
+ exports2.add(export);
+ });
checkElementListIdentities(
- element1, element2, 'exportScope',
- LibrarySerializer.getExportedElements(element1),
- LibrarySerializer.getExportedElements(element2));
+ element1, element2, 'exportScope', exports1, exports2);
}
@override
« no previous file with comments | « tests/compiler/dart2js/serialization_analysis_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698