Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1808123006: Tweaks to compile against latest analyzer. Also changes the travis (Closed)

Created:
4 years, 9 months ago by Leaf
Modified:
4 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweaks to compile against latest analyzer. Also changes the travis setup to only override analyzer dependencies when $ANALYZER is explicitly set to master. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/37856623a0d5c9f1a78e7fffab3a1634a520352f

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -43 lines) Patch
M .travis.yml View 1 chunk +1 line, -1 line 1 comment Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/reify_coercions.dart View 5 chunks +9 lines, -32 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M tool/sdk_expected_errors.txt View 6 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
https://codereview.chromium.org/1808123006/diff/1/.travis.yml File .travis.yml (right): https://codereview.chromium.org/1808123006/diff/1/.travis.yml#newcode11 .travis.yml:11: - test "$ANALYZER" != master || ./tool/override_analyzer_dependency.sh The previous ...
4 years, 9 months ago (2016-03-18 23:54:39 UTC) #2
Bob Nystrom
LGTM! Nice to see the code in DDC get smaller with the Coercion clean up ...
4 years, 9 months ago (2016-03-19 00:01:47 UTC) #3
Leaf
4 years, 9 months ago (2016-03-19 03:57:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
37856623a0d5c9f1a78e7fffab3a1634a520352f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698