Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1808123005: First batch of changes to make analyzer package strong mode error free (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

First batch of changes to make analyzer package strong mode error free Committed: https://github.com/dart-lang/sdk/commit/5309d864240807e1cf71f2577d07a301dcb18f2f

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -184 lines) Patch
M pkg/analyzer/lib/dart/ast/ast.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/source/error_processor.dart View 3 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/source/sdk_ext.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 108 chunks +215 lines, -108 lines 4 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 2 chunks +12 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +11 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +1 line, -1 line 2 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_general.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/options_plugin.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/inputs.dart View 4 chunks +23 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/enum_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-18 00:02:24 UTC) #2
Leaf
https://codereview.chromium.org/1808123005/diff/1/pkg/analyzer/lib/src/dart/ast/ast.dart File pkg/analyzer/lib/src/dart/ast/ast.dart (right): https://codereview.chromium.org/1808123005/diff/1/pkg/analyzer/lib/src/dart/ast/ast.dart#newcode62 pkg/analyzer/lib/src/dart/ast/ast.dart:62: dynamic /* =E */ accept/*<E>*/(AstVisitor/*<E>*/ visitor) => The = ...
4 years, 9 months ago (2016-03-18 00:41:06 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1808123005/diff/1/pkg/analyzer/lib/src/dart/ast/ast.dart File pkg/analyzer/lib/src/dart/ast/ast.dart (right): https://codereview.chromium.org/1808123005/diff/1/pkg/analyzer/lib/src/dart/ast/ast.dart#newcode62 pkg/analyzer/lib/src/dart/ast/ast.dart:62: dynamic /* =E */ accept/*<E>*/(AstVisitor/*<E>*/ visitor) => Done, 108 ...
4 years, 9 months ago (2016-03-18 14:46:24 UTC) #4
Brian Wilkerson
Committed patchset #1 (id:1) manually as 5309d864240807e1cf71f2577d07a301dcb18f2f (presubmit successful).
4 years, 9 months ago (2016-03-18 14:48:00 UTC) #6
Leaf
4 years, 9 months ago (2016-03-18 16:23:32 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698