Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(76)

Issue 1808123003: win: Fix another intrinsic include. (Closed)

Created:
3 years ago by Nico
Modified:
3 years ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

win: Fix another intrinsic include. _mm_getcsr is declared in intrin.h, see https://msdn.microsoft.com/en-us/library/hh977022.aspx This worked because transitive includes ended up pulling in winnt.h, which also declares this function (and tells the compiler to use a built-in). The built-in mechanism doesn't work with clang-cl (see http://llvm.org/PR19898 comment 10) and leads to a linker error. Since the file tries to include the right header for _mm_getcsr, just fix the include, which happens to make things link with clang-cl too. This should have been part of https://codereview.chromium.org/1778653002/ BUG=https://crbug.com/592745 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/06cacd6becc3f033d03fab97e6fa9ef99d9b41f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/trusted/service_runtime/arch/x86_64/sel_rt_64.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
3 years ago (2016-03-17 16:37:30 UTC) #2
Roland McGrath
lgtm
3 years ago (2016-03-17 18:38:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808123003/1
3 years ago (2016-03-17 18:42:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: nacl-win8-64_newlib_dbg on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-win8-64_newlib_dbg/builds/5074)
3 years ago (2016-03-17 20:54:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808123003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808123003/1
3 years ago (2016-03-17 22:16:49 UTC) #9
commit-bot: I haz the power
3 years ago (2016-03-17 23:23:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/06cacd6be...

Powered by Google App Engine
This is Rietveld 408576698