Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1808093002: mb_config.pyl cleanup: remove unused dev configs from MB. (Closed)

Created:
4 years, 9 months ago by Dirk Pranke
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mb_config.pyl cleanup: remove unused dev configs from MB. MB was originally intended to be used to manage non-bot configs as well, but we ended up not using this. This CL removes a bunch of associated code that was hence no longer needed. R=jbudorick@chromium.org, kjellander@chromium.org BUG= Committed: https://crrev.com/3be0014fbf3c6f393e9726d086d5de4a6528ffde Cr-Commit-Position: refs/heads/master@{#381818}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -106 lines) Patch
M tools/mb/mb.py View 3 chunks +3 lines, -30 lines 0 comments Download
M tools/mb/mb_config.pyl View 3 chunks +0 lines, -44 lines 0 comments Download
M tools/mb/mb_unittest.py View 1 13 chunks +25 lines, -32 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Dirk Pranke
FYI ... I *think* this will be backwards-compatible with your respective config files, but you ...
4 years, 9 months ago (2016-03-17 02:10:42 UTC) #1
kjellander_chromium
thanks for the heads up. lgtm https://codereview.chromium.org/1808093002/diff/1/tools/mb/mb_unittest.py File tools/mb/mb_unittest.py (right): https://codereview.chromium.org/1808093002/diff/1/tools/mb/mb_unittest.py#newcode384 tools/mb/mb_unittest.py:384: '/tmp/in.json', '/tmp/out.json'], ret=0) ...
4 years, 9 months ago (2016-03-17 05:04:31 UTC) #2
jbudorick
lgtm
4 years, 9 months ago (2016-03-17 13:05:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808093002/20001
4 years, 9 months ago (2016-03-17 20:38:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 22:46:12 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:48:07 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3be0014fbf3c6f393e9726d086d5de4a6528ffde
Cr-Commit-Position: refs/heads/master@{#381818}

Powered by Google App Engine
This is Rietveld 408576698