Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1808073002: Add empty implementation of ThreadedInputConnection.deleteSurroundingTextInCodePoints(). (Closed)

Created:
4 years, 9 months ago by newt (away)
Modified:
4 years, 9 months ago
Reviewers:
Changwan Ryu
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add empty implementation of ThreadedInputConnection.deleteSurroundingTextInCodePoints(). This is needed to allow building with the N preview SDK. BUG=595525, 595522 Committed: https://crrev.com/75d7160d39b1928b8afe65323d9fed7fe7a7e379 Cr-Commit-Position: refs/heads/master@{#381652}

Patch Set 1 #

Total comments: 2

Patch Set 2 : returned false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
newt (away)
PTAL This short-term fix is needed to use the N preview SDK (see linked bug). ...
4 years, 9 months ago (2016-03-17 01:33:27 UTC) #2
Changwan Ryu
lgtm actually this should not happen because there are apps who directly implement InputConnection interface. ...
4 years, 9 months ago (2016-03-17 01:40:19 UTC) #3
newt (away)
Thanks for the quick review :) https://codereview.chromium.org/1808073002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java File content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java (right): https://codereview.chromium.org/1808073002/diff/1/content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java#newcode405 content/public/android/java/src/org/chromium/content/browser/input/ThreadedInputConnection.java:405: throw new UnsupportedOperationException("Not ...
4 years, 9 months ago (2016-03-17 01:55:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1808073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1808073002/20001
4 years, 9 months ago (2016-03-17 01:58:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 03:14:28 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 03:16:09 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75d7160d39b1928b8afe65323d9fed7fe7a7e379
Cr-Commit-Position: refs/heads/master@{#381652}

Powered by Google App Engine
This is Rietveld 408576698